From: Ralf Baechle <ralf@linux-mips.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] IDE: Fix platform device registration in Swarm IDE driver
Date: Sun, 28 Sep 2008 12:47:11 +0100 [thread overview]
Message-ID: <20080928114711.GB9207@linux-mips.org> (raw)
In-Reply-To: <48DA1F9D.6000501@ru.mvista.com>
On Wed, Sep 24, 2008 at 03:08:13PM +0400, Sergei Shtylyov wrote:
>> +{
>>
> [...]
>> + pdev = platform_device_register_simple(DEV_NAME, -1,
>> + swarm_ide_resource, ARRAY_SIZE(swarm_ide_resource));
>>
>
> If you have the resources as static array anyway, why not have the
> device in the static variable too and use platform_device_register()?
It saves a few lines of code.
>> -static struct platform_device *swarm_ide_dev;
>>
>
> Platform device in the driver itself? Interesting... :-)
It works and isn't a too bad idea for certain drivers where adding one half
of the code to a platform file, another to the driver file is just too
much fuzz. It's just that this wasn't done right in case of the Swarm so
I'm gluing that now.
Ralf
next prev parent reply other threads:[~2008-09-28 11:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 12:29 [PATCH] IDE: Fix platform device registration in Swarm IDE driver Ralf Baechle
2008-09-24 11:08 ` Sergei Shtylyov
2008-09-24 13:52 ` Maciej W. Rozycki
2008-09-27 23:51 ` Ralf Baechle
2008-09-27 16:59 ` Bartlomiej Zolnierkiewicz
2008-09-28 9:22 ` Sergei Shtylyov
2008-09-28 11:39 ` Ralf Baechle
2008-09-28 13:12 ` Sergei Shtylyov
2008-09-28 17:54 ` [PATCH v2] " Ralf Baechle
2008-09-28 21:51 ` Sergei Shtylyov
2008-09-28 21:57 ` Ralf Baechle
2008-09-29 8:00 ` Sergei Shtylyov
2008-10-03 17:00 ` Bartlomiej Zolnierkiewicz
2008-10-03 18:25 ` Ralf Baechle
2008-09-28 11:47 ` Ralf Baechle [this message]
2008-09-28 12:51 ` [PATCH] " Sergei Shtylyov
2008-09-28 17:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080928114711.GB9207@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).