From: Andrew Morton <akpm@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-ide@vger.kernel.org, Thomas Renninger <trenn@suse.de>,
Robert Hancock <hancockr@shaw.ca>,
LKML <linux-kernel@vger.kernel.org>,
Frans Pop <elendil@planet.nl>,
Maciej Rutecki <maciej.rutecki@gmail.com>
Subject: Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation
Date: Fri, 3 Oct 2008 01:35:57 -0700 [thread overview]
Message-ID: <20081003013557.42ce685d.akpm@linux-foundation.org> (raw)
In-Reply-To: <200809300010.39000.rjw@sisk.pl>
On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> Hibernation: Introduce new system state for the last phase of hibernation
>
> Replace unused SYSTEM_SUSPEND_DISK with a new system_state value
> SYSTEM_HIBERNATE_ENTER that can be used by device drivers to check if
> the system is in the last phase of hibernation.
Violent objections.
We just don't know what this change will do. It potentially affects
every code site in the kernel which looks at system_state. We've had
problems in the past with this thing and the more complex we make it,
the worse any future problems will be. It's Just Bad.
Can we just create a new global?
extern bool system_entering_hibernation_or_whatever;
?
It'll add four bytes of bss, it'll save *more* than four bytes of
text and it is plainly obviously non-injurious to present and future
code.
hmm?
next prev parent reply other threads:[~2008-10-03 8:36 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 22:02 Regression: SATA disk double spin-off during hibernation on hp nx6325 Rafael J. Wysocki
2008-08-29 10:03 ` Tejun Heo
2008-08-29 10:41 ` Rafael J. Wysocki
2008-08-29 10:42 ` Tejun Heo
2008-09-06 17:23 ` [PATCH] SATA: Blacklist systems that spin off disks during ACPI power off Rafael J. Wysocki
2008-09-08 11:38 ` Tejun Heo
2008-09-14 2:21 ` Jeff Garzik
2008-09-15 0:00 ` Rafael J. Wysocki
2008-09-17 21:50 ` Jeff Garzik
2008-09-29 22:06 ` [PATCH 0/6] " Rafael J. Wysocki
2008-09-29 22:10 ` [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Rafael J. Wysocki
2008-10-01 3:32 ` Tejun Heo
2008-10-01 11:36 ` Rafael J. Wysocki
2008-10-03 8:35 ` Andrew Morton [this message]
2008-10-03 11:27 ` Rafael J. Wysocki
2008-10-03 12:43 ` Andrew Morton
2008-10-03 15:03 ` Rafael J. Wysocki
2008-10-03 21:48 ` [PATCH 0/6] SATA: Blacklist systems that spin off disks during ACPI power off (rev. 2) Rafael J. Wysocki
2008-10-03 21:51 ` [PATCH 1/6] Hibernation: Introduce system_entering_hibernation Rafael J. Wysocki
2008-10-03 23:27 ` Alan Cox
2008-10-04 10:13 ` Rafael J. Wysocki
2008-10-04 21:50 ` Alan Cox
2008-10-04 21:52 ` Tejun Heo
2008-10-04 22:30 ` Rafael J. Wysocki
2008-10-04 22:27 ` Tejun Heo
2008-10-04 7:02 ` Tejun Heo
2008-10-04 10:14 ` Rafael J. Wysocki
2008-10-03 21:52 ` [PATCH 2/6] DMI: Introduce dmi_first_match to make the interface more flexible Rafael J. Wysocki
2008-10-03 21:57 ` [PATCH 3/6] SATA: Blacklisting of systems that spin off disks during ACPI power off (rev. 2) Rafael J. Wysocki
2008-10-03 21:57 ` [PATCH 4/6] SATA AHCI: Blacklist system that spins off disks during ACPI power off Rafael J. Wysocki
2008-10-03 21:58 ` [PATCH 5/6] SATA Sil: " Rafael J. Wysocki
2008-10-03 21:58 ` [PATCH 6/6] SATA PIIX: " Rafael J. Wysocki
2008-10-03 12:49 ` [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Arjan van de Ven
2008-10-03 15:05 ` Rafael J. Wysocki
2008-09-29 22:13 ` [PATCH 2/6] DMI: Introduce dmi_first_match to make the interface more flexible Rafael J. Wysocki
2008-10-01 3:31 ` Tejun Heo
2008-09-29 22:14 ` [PATCH 3/6] SATA: Blacklisting of systems that spin off disks during ACPI power off Rafael J. Wysocki
2008-10-01 3:34 ` Tejun Heo
2008-10-01 11:36 ` Rafael J. Wysocki
2008-09-29 22:15 ` [PATCH 4/6] SATA AHCI: Blacklist system that spins " Rafael J. Wysocki
2008-09-29 22:16 ` [PATCH 5/6] SATA Sil: " Rafael J. Wysocki
2008-09-29 22:18 ` [PATCH 6/6] SATA PIIX: " Rafael J. Wysocki
[not found] ` <200808291245.27436.elendil@planet.nl>
2008-08-29 10:57 ` Regression: SATA disk double spin-off during hibernation on hp nx6325 Rafael J. Wysocki
2008-08-29 11:30 ` Frans Pop
2008-09-04 14:05 ` Rafael J. Wysocki
2008-09-05 22:25 ` Frans Pop
2008-09-05 23:18 ` Rafael J. Wysocki
2008-09-06 0:09 ` Frans Pop
2008-09-06 11:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003013557.42ce685d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=rjw@sisk.pl \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).