* Re: New CD/DVD reports 'Can Play Audio NO'
[not found] <bjbMi-2A6-1@gated-at.bofh.it>
@ 2008-10-04 11:26 ` Bodo Eggert
2008-10-04 11:52 ` Nick Warne
2008-10-04 13:41 ` Borislav Petkov
0 siblings, 2 replies; 7+ messages in thread
From: Bodo Eggert @ 2008-10-04 11:26 UTC (permalink / raw)
To: Nick Warne, petkovbb, linux-ide
Nick Warne <nick@ukfsn.org> wrote:
> Very strange issue. I recently bought a new machine that came with a
> CD/DVD burner. All functions normally, except I cannot play audio CD.
>
> Information:
>
> Slackware 12.1 running latest stable kernel 2.6.26.5
>
> The drive is:
>
> Vendor : Optiarc
> Model : DVD RW AD-7200A
> Revision : 1.06
>
> Now, I have another drive (I purchased last year) that could play audio
> CD, so I installed that as master, and put the new drive as slave
> (old->hda new->hdb). The old(er) drive can and does play audio OK.
>
> I see this in /proc/sys/dev/cdrom/info:
> Can play audio: 0 1
Same as
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/186664/comments/9
Please complain to the vendor, so he stops doing this bull*.
Signed-Off-By: Bodo Eggert
X-Tested: Not at all
--- linux-2.6.26/drivers/ide/ide-cd.c.ori 2008-10-04 13:21:17.000000000 +0200
+++ linux-2.6.26/drivers/ide/ide-cd.c 2008-10-04 13:22:15.000000000 +0200
@@ -1842,6 +1842,7 @@ static const struct cd_list_entry ide_cd
{ "MATSHITADVD-ROM SR-8176", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
{ "MATSHITADVD-ROM SR-8174", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
{ "Optiarc DVD RW AD-5200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
+ { "Optiarc DVD RW AD-7200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
{ NULL, NULL, 0 }
};
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New CD/DVD reports 'Can Play Audio NO'
2008-10-04 11:26 ` New CD/DVD reports 'Can Play Audio NO' Bodo Eggert
@ 2008-10-04 11:52 ` Nick Warne
2008-10-04 12:41 ` Nick Warne
2008-10-04 13:41 ` Borislav Petkov
1 sibling, 1 reply; 7+ messages in thread
From: Nick Warne @ 2008-10-04 11:52 UTC (permalink / raw)
To: 7eggert; +Cc: petkovbb, linux-ide, D Bray
On Sat, 04 Oct 2008 13:26:44 +0200
Bodo Eggert <7eggert@gmx.de> wrote:
> Nick Warne <nick@ukfsn.org> wrote:
>
> > Very strange issue. I recently bought a new machine that came with
> > a CD/DVD burner. All functions normally, except I cannot play
> > audio CD.
> >
> > Information:
> >
> > Slackware 12.1 running latest stable kernel 2.6.26.5
> >
> > The drive is:
> >
> > Vendor : Optiarc
> > Model : DVD RW AD-7200A
> > Revision : 1.06
> >
> > Now, I have another drive (I purchased last year) that could play
> > audio CD, so I installed that as master, and put the new drive as
> > slave (old->hda new->hdb). The old(er) drive can and does play
> > audio OK.
> >
> > I see this in /proc/sys/dev/cdrom/info:
>
> > Can play audio: 0 1
>
> Same as
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/186664/comments/9
>
> Please complain to the vendor, so he stops doing this bull*.
>
> Signed-Off-By: Bodo Eggert
> X-Tested: Not at all
>
> --- linux-2.6.26/drivers/ide/ide-cd.c.ori 2008-10-04
> 13:21:17.000000000 +0200 +++ linux-2.6.26/drivers/ide/ide-cd.c
> 2008-10-04 13:22:15.000000000 +0200 @@ -1842,6 +1842,7 @@ static
> const struct cd_list_entry ide_cd { "MATSHITADVD-ROM SR-8176",
> NULL, IDE_CD_FLAG_PLAY_AUDIO_OK }, { "MATSHITADVD-ROM
> SR-8174", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK }, { "Optiarc DVD RW
> AD-5200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
> + { "Optiarc DVD RW AD-7200A", NULL,
> IDE_CD_FLAG_PLAY_AUDIO_OK }, { NULL, NULL, 0 }
> };
>
Thank you Bodo. This works fine now.
I guessed there might be a crapture list for buggy firmware CD drives,
but didn't find it...
The patch is fine.
Acked-by: Nick Warne <nick@ukfsn.org>
Nick
--
Free Software Foundation Associate Member 5508
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New CD/DVD reports 'Can Play Audio NO'
2008-10-04 11:52 ` Nick Warne
@ 2008-10-04 12:41 ` Nick Warne
0 siblings, 0 replies; 7+ messages in thread
From: Nick Warne @ 2008-10-04 12:41 UTC (permalink / raw)
Cc: 7eggert, petkovbb, linux-ide, D Bray
On Sat, 4 Oct 2008 12:52:23 +0100
Nick Warne <nick@ukfsn.org> wrote:
> On Sat, 04 Oct 2008 13:26:44 +0200
> Bodo Eggert <7eggert@gmx.de> wrote:
>
> > Nick Warne <nick@ukfsn.org> wrote:
> >
> > > Very strange issue. I recently bought a new machine that came
> > > with a CD/DVD burner. All functions normally, except I cannot
> > > play audio CD.
> > >
> > > Information:
> > >
> > > Slackware 12.1 running latest stable kernel 2.6.26.5
> > >
> > > The drive is:
> > >
> > > Vendor : Optiarc
> > > Model : DVD RW AD-7200A
> > > Revision : 1.06
> > >
> > > Now, I have another drive (I purchased last year) that could play
> > > audio CD, so I installed that as master, and put the new drive as
> > > slave (old->hda new->hdb). The old(er) drive can and does play
> > > audio OK.
> > >
> > > I see this in /proc/sys/dev/cdrom/info:
> >
> > > Can play audio: 0 1
> >
> > Same as
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/186664/comments/9
> >
> > Please complain to the vendor, so he stops doing this bull*.
> >
> > Signed-Off-By: Bodo Eggert
> > X-Tested: Not at all
> >
> > --- linux-2.6.26/drivers/ide/ide-cd.c.ori 2008-10-04
> > 13:21:17.000000000 +0200 +++ linux-2.6.26/drivers/ide/ide-cd.c
> > 2008-10-04 13:22:15.000000000 +0200 @@ -1842,6 +1842,7 @@ static
> > const struct cd_list_entry ide_cd { "MATSHITADVD-ROM SR-8176",
> > NULL, IDE_CD_FLAG_PLAY_AUDIO_OK }, { "MATSHITADVD-ROM
> > SR-8174", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK }, { "Optiarc DVD
> > RW AD-5200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
> > + { "Optiarc DVD RW AD-7200A", NULL,
> > IDE_CD_FLAG_PLAY_AUDIO_OK }, { NULL, NULL, 0 }
> > };
> >
>
> Thank you Bodo. This works fine now.
>
> I guessed there might be a crapture list for buggy firmware CD drives,
> but didn't find it...
>
> The patch is fine.
>
> Acked-by: Nick Warne <nick@ukfsn.org>
Sorry, I used the wrong tag.
Test-by: Nick Warne <nick@ukfsn.org>
--
Free Software Foundation Associate Member 5508
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New CD/DVD reports 'Can Play Audio NO'
2008-10-04 11:26 ` New CD/DVD reports 'Can Play Audio NO' Bodo Eggert
2008-10-04 11:52 ` Nick Warne
@ 2008-10-04 13:41 ` Borislav Petkov
2008-10-04 14:27 ` [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio Bodo Eggert
1 sibling, 1 reply; 7+ messages in thread
From: Borislav Petkov @ 2008-10-04 13:41 UTC (permalink / raw)
To: Bodo Eggert; +Cc: Nick Warne, linux-ide, bzolnier
On Sat, Oct 04, 2008 at 01:26:44PM +0200, Bodo Eggert wrote:
> Nick Warne <nick@ukfsn.org> wrote:
>
> > Very strange issue. I recently bought a new machine that came with a
> > CD/DVD burner. All functions normally, except I cannot play audio CD.
> >
> > Information:
> >
> > Slackware 12.1 running latest stable kernel 2.6.26.5
> >
> > The drive is:
> >
> > Vendor : Optiarc
> > Model : DVD RW AD-7200A
> > Revision : 1.06
> >
> > Now, I have another drive (I purchased last year) that could play audio
> > CD, so I installed that as master, and put the new drive as slave
> > (old->hda new->hdb). The old(er) drive can and does play audio OK.
> >
> > I see this in /proc/sys/dev/cdrom/info:
>
> > Can play audio: 0 1
>
> Same as
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/186664/comments/9
>
> Please complain to the vendor, so he stops doing this bull*.
>
> Signed-Off-By: Bodo Eggert
> X-Tested: Not at all
>
> --- linux-2.6.26/drivers/ide/ide-cd.c.ori 2008-10-04 13:21:17.000000000 +0200
> +++ linux-2.6.26/drivers/ide/ide-cd.c 2008-10-04 13:22:15.000000000 +0200
> @@ -1842,6 +1842,7 @@ static const struct cd_list_entry ide_cd
> { "MATSHITADVD-ROM SR-8176", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
> { "MATSHITADVD-ROM SR-8174", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
> { "Optiarc DVD RW AD-5200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
> + { "Optiarc DVD RW AD-7200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
> { NULL, NULL, 0 }
> };
ACK, although I vehemently object all those driver bloating lists of model
names. I'll think of something better. In the meantime, Bodo do you care to redo
your patch according to Documentation/SubmittingPatches? E.g. it is missing a
comment, the Signed-off-by: misses an email address, etc.
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio
2008-10-04 13:41 ` Borislav Petkov
@ 2008-10-04 14:27 ` Bodo Eggert
2008-10-04 14:57 ` Borislav Petkov
0 siblings, 1 reply; 7+ messages in thread
From: Bodo Eggert @ 2008-10-04 14:27 UTC (permalink / raw)
To: petkovbb; +Cc: Bodo Eggert, Nick Warne, linux-ide, bzolnier
The Optiarc DVD RW AD-7200A can play audio, but tells it could not.
Signed-Off-By: Bodo Eggert <7eggert@gmx.de>
Test-by: Nick Warne <nick@ukfsn.org>
X-Kernel-Version: 2.6.26
--- linux-2.6.26/drivers/ide/ide-cd.c.ori 2008-10-04 13:21:17.000000000 +0200
+++ linux-2.6.26/drivers/ide/ide-cd.c 2008-10-04 13:22:15.000000000 +0200
@@ -1842,6 +1842,7 @@ static const struct cd_list_entry ide_cd
{ "MATSHITADVD-ROM SR-8176", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
{ "MATSHITADVD-ROM SR-8174", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
{ "Optiarc DVD RW AD-5200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
+ { "Optiarc DVD RW AD-7200A", NULL, IDE_CD_FLAG_PLAY_AUDIO_OK },
{ NULL, NULL, 0 }
};
--
Funny quotes:
15. I drive way too fast to worry about cholesterol.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio
2008-10-04 14:27 ` [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio Bodo Eggert
@ 2008-10-04 14:57 ` Borislav Petkov
2008-10-05 16:04 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 7+ messages in thread
From: Borislav Petkov @ 2008-10-04 14:57 UTC (permalink / raw)
To: Bodo Eggert, bzolnier; +Cc: Nick Warne, linux-ide
On Sat, Oct 04, 2008 at 04:27:25PM +0200, Bodo Eggert wrote:
> The Optiarc DVD RW AD-7200A can play audio, but tells it could not.
>
> Signed-Off-By: Bodo Eggert <7eggert@gmx.de>
> Test-by: Nick Warne <nick@ukfsn.org>
> X-Kernel-Version: 2.6.26
This one doesn't apply cleanly since it is against 2.6.26. Here's a current
version ontop of pata-tree:
--
From: Bodo Eggert <7eggert@gmx.de>
Subject: [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio
The Optiarc DVD RW AD-7200A can play audio, but tells it could not.
Signed-Off-By: Bodo Eggert <7eggert@gmx.de>
Tested-by: Nick Warne <nick@ukfsn.org>
---
drivers/ide/ide-cd.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 63eada0..db87fab 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -1965,6 +1965,7 @@ static const struct cd_list_entry ide_cd_quirks_list[] = {
{ "MATSHITADVD-ROM SR-8174", NULL, IDE_AFLAG_PLAY_AUDIO_OK },
{ "Optiarc DVD RW AD-5200A", NULL, IDE_AFLAG_PLAY_AUDIO_OK },
{ "Optiarc DVD RW AD-7543A", NULL, IDE_AFLAG_NO_AUTOCLOSE },
+ { "Optiarc DVD RW AD-7200A", NULL, IDE_AFLAG_PLAY_AUDIO_OK },
{ NULL, NULL, 0 }
};
--
1.5.5.4
--
Regards/Gruss,
Boris.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio
2008-10-04 14:57 ` Borislav Petkov
@ 2008-10-05 16:04 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-10-05 16:04 UTC (permalink / raw)
To: petkovbb; +Cc: Bodo Eggert, Nick Warne, linux-ide
On Saturday 04 October 2008, Borislav Petkov wrote:
> On Sat, Oct 04, 2008 at 04:27:25PM +0200, Bodo Eggert wrote:
> > The Optiarc DVD RW AD-7200A can play audio, but tells it could not.
> >
> > Signed-Off-By: Bodo Eggert <7eggert@gmx.de>
> > Test-by: Nick Warne <nick@ukfsn.org>
> > X-Kernel-Version: 2.6.26
>
> This one doesn't apply cleanly since it is against 2.6.26. Here's a current
> version ontop of pata-tree:
>
> --
> From: Bodo Eggert <7eggert@gmx.de>
> Subject: [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio
>
> The Optiarc DVD RW AD-7200A can play audio, but tells it could not.
>
> Signed-Off-By: Bodo Eggert <7eggert@gmx.de>
> Tested-by: Nick Warne <nick@ukfsn.org>
thanks, applied
> ---
> drivers/ide/ide-cd.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 63eada0..db87fab 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1965,6 +1965,7 @@ static const struct cd_list_entry ide_cd_quirks_list[] = {
> { "MATSHITADVD-ROM SR-8174", NULL, IDE_AFLAG_PLAY_AUDIO_OK },
> { "Optiarc DVD RW AD-5200A", NULL, IDE_AFLAG_PLAY_AUDIO_OK },
> { "Optiarc DVD RW AD-7543A", NULL, IDE_AFLAG_NO_AUTOCLOSE },
> + { "Optiarc DVD RW AD-7200A", NULL, IDE_AFLAG_PLAY_AUDIO_OK },
I moved this one line up to keep "audio" quirks together.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-10-05 16:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bjbMi-2A6-1@gated-at.bofh.it>
2008-10-04 11:26 ` New CD/DVD reports 'Can Play Audio NO' Bodo Eggert
2008-10-04 11:52 ` Nick Warne
2008-10-04 12:41 ` Nick Warne
2008-10-04 13:41 ` Borislav Petkov
2008-10-04 14:27 ` [PATCH] ide-cd: Optiarc DVD RW AD-7200A does play audio Bodo Eggert
2008-10-04 14:57 ` Borislav Petkov
2008-10-05 16:04 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).