linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: David Miller <davem@davemloft.net>,
	alan@lxorguk.ukuu.org.uk, arjan@linux.intel.com,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, netdev@vger.kernel.org,
	linux-acpi@vger.kernel.org, tglx@tglx.de, tytso@mit.edu,
	linux-ide@vger.kernel.org
Subject: Re: Top kernel oopses/warnings for the week of October 7th, 2008
Date: Wed, 8 Oct 2008 11:21:36 +0200	[thread overview]
Message-ID: <20081008092136.GA22387@elte.hu> (raw)
In-Reply-To: <200810081106.55730.rjw@sisk.pl>


* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> On Wednesday, 8 of October 2008, David Miller wrote:
> > From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Date: Tue, 7 Oct 2008 23:58:33 +0100
> > 
> > > > This should have been fixed by:
> > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f5a6d958b5d0a10e7e7a9dee1862fb31d08c6d26
> > > 
> > > You mean - hidden by - that change should IMHO be reverted
> > 
> > Grrr... I totally agree.
> 
> Even though they are false positives in many cases?
> 
> (Yes, they are).

it's your judgement call i guess - i just wanted to challenge the 
terminology of calling it a fix ;-)

Can you think of any good way of reintroducing the good aspect of the 
WARN(), without the false positives? [ If not, and if the WARN()s do 
more harm than good then it's the right change. ]

But generally the trend is the opposite direction: we try to add as many 
WARN()s as possible, and we need even more good WARN()s in the kernel. 
When we meet false positives we try to improve the quality/yield of the 
warning, not eliminate it.

Granted, they are a bit embarrassing when they show up in the top 10 but 
they are also very helpful and are tracked very nicely and lead to 
actual bugfixes that _matter_.

Kerneloops.org is a wonderful tool: it enables a broad spectrum of users 
to help us out with their feedback, without them being forced into any 
manual work, and without them having to understand the kernel bug 
reporting workflow. Its scale is already enormous: 3000+ bugs reported 
per week. (many kudos Arjan!)

Once its growth stabilizes (all the large distros have it either enabled 
today or have the client in their pipeline) we can even observe 
long-term trends and estimate release-to-release suckiness. That was 
impossible before and maintainers were left largely to imprecise 
intuitive guesses about where we stand wrt. kernel quality.

	Ingo

  reply	other threads:[~2008-10-08  9:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-07 19:52 Top kernel oopses/warnings for the week of October 7th, 2008 Arjan van de Ven
2008-10-07 20:13 ` Rafael J. Wysocki
2008-10-07 20:16   ` Ingo Molnar
2008-10-07 20:37     ` Rafael J. Wysocki
2008-10-07 22:58   ` Alan Cox
2008-10-07 23:08     ` David Miller
2008-10-08  9:06       ` Rafael J. Wysocki
2008-10-08  9:21         ` Ingo Molnar [this message]
2008-10-08 12:43           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081008092136.GA22387@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tglx@tglx.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).