From: Jens Axboe <jens.axboe@oracle.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] ide: locking improvements
Date: Thu, 9 Oct 2008 08:51:43 +0200 [thread overview]
Message-ID: <20081009065141.GV19428@kernel.dk> (raw)
In-Reply-To: <20081008202930.19112.90371.sendpatchset@localhost.localdomain>
On Wed, Oct 08 2008, Bartlomiej Zolnierkiewicz wrote:
>
> Locking improvements in preparation for replacing the global ide_lock
> spinlock by per-hwgroup spinlocks [1].
>
> [1] patch (which is partially based on 2005 patch from Scalex86) for this
> is also ready but it needs some more audit and testing
>
> diffstat:
> drivers/ide/ide-cd.c | 38 ++++++-------
> drivers/ide/ide-io.c | 129 ++++++++++++++++++++---------------------------
> drivers/ide/ide-ioctls.c | 3 -
> drivers/ide/ide-lib.c | 7 --
> drivers/ide/ide-proc.c | 25 +--------
> drivers/ide/ide.c | 7 --
> 6 files changed, 80 insertions(+), 129 deletions(-)
Sorry, but I just have to ask 'why'? IDE is seeing a whole lot of churn
for something that should essentially be a stable code base in
maintenance mode, and now scalability improvements?
Just doesn't make ANY sense to me, sorry. We may end up with a cleaner
code base, but likely also a buggier one. It's not like hardware
coverage testing is all that great, considering some of the ancient
stuff it supports :-)
--
Jens Axboe
next prev parent reply other threads:[~2008-10-09 6:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 20:29 [PATCH 0/7] ide: locking improvements Bartlomiej Zolnierkiewicz
2008-10-08 20:29 ` [PATCH 1/7] ide: unify ide_intr()'s exit points Bartlomiej Zolnierkiewicz
2008-10-08 20:29 ` [PATCH 2/7] ide: IDE settings don't need an ide_lock held Bartlomiej Zolnierkiewicz
2008-10-08 20:29 ` [PATCH 3/7] ide: __ide_port_unregister_devices() doesn't " Bartlomiej Zolnierkiewicz
2008-10-08 20:30 ` [PATCH 4/7] ide: ide_hwgroup_t.rq " Bartlomiej Zolnierkiewicz
2008-10-10 8:34 ` Elias Oltmanns
2008-10-10 9:01 ` Jens Axboe
2008-10-10 9:37 ` Elias Oltmanns
2008-10-10 10:17 ` Jens Axboe
2008-10-10 16:20 ` Bartlomiej Zolnierkiewicz
2008-10-08 20:30 ` [PATCH 5/7] ide: push ide_lock to __ide_end_request() Bartlomiej Zolnierkiewicz
2008-10-08 20:30 ` [PATCH 6/7] ide: ide_lock + __blk_end_request() -> blk_end_request() Bartlomiej Zolnierkiewicz
2008-10-08 20:30 ` [PATCH 7/7] ide: use queue lock instead of ide_lock when possible Bartlomiej Zolnierkiewicz
2008-10-10 8:43 ` Elias Oltmanns
2008-10-10 8:52 ` Jens Axboe
2008-10-10 11:35 ` Jens Axboe
2008-10-09 6:51 ` Jens Axboe [this message]
2008-10-09 8:36 ` [PATCH 0/7] ide: locking improvements Bartlomiej Zolnierkiewicz
2008-10-09 8:40 ` Jens Axboe
[not found] <fa.Ke90oacfRjgiI4x5LejzjssRBEg@ifi.uio.no>
[not found] ` <fa.5sGSpBgVBoMAsIwwLABWnjDzM38@ifi.uio.no>
[not found] ` <fa.8TkQ+xA96EhlNKL9gIbVTxVrcUE@ifi.uio.no>
2008-10-11 2:34 ` Robert Hancock
2008-10-11 11:39 ` Bartlomiej Zolnierkiewicz
2008-10-11 12:01 ` Borislav Petkov
2008-10-11 13:53 ` Jens Axboe
2008-10-11 14:45 ` Bartlomiej Zolnierkiewicz
2008-10-11 15:05 ` Jens Axboe
2008-10-11 15:56 ` Bartlomiej Zolnierkiewicz
2008-10-11 17:06 ` Borislav Petkov
2008-10-11 17:56 ` Jens Axboe
2008-10-11 17:56 ` Jens Axboe
2008-10-11 18:34 ` Borislav Petkov
2008-10-11 18:46 ` Bartlomiej Zolnierkiewicz
2008-10-12 1:38 ` Robert Hancock
2008-10-12 9:05 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009065141.GV19428@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).