From: Jens Axboe <jens.axboe@oracle.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, torvalds@osdl.org
Subject: Re: libata: set queue SSD flag for SSD devices
Date: Sat, 11 Oct 2008 16:06:01 +0200 [thread overview]
Message-ID: <20081011140600.GR19428@kernel.dk> (raw)
In-Reply-To: <1223710417.4159.11.camel@localhost.localdomain>
On Sat, Oct 11 2008, James Bottomley wrote:
> On Fri, 2008-10-10 at 17:55 -0700, Arjan van de Ven wrote:
> > On Fri, 10 Oct 2008 22:05:28 +0200
> > Jens Axboe <jens.axboe@oracle.com> wrote:
> > >
> > > In this specific patch, it'll do no harm at least since I very much
> > > doubt we'll see a false positive. And even if, the consequences wont
> > > be dire. But it does want the version check, of course.
> > >
> >
> > also, is "is an ssd" the right question or is "doesn't have seek
> > latency" the right one?
> > (difference is.. well EMC boxes with lots of ram etc)
>
> For libata, the is ssd is the right test.
>
> For things like the symmetrix we probably need to look at the caching
> mode page and treat it like ssd if the cache is say > 1GB or whatever
> heuristic is needed.
Still wont quite work, you're still going to have occasional seek
latencies no matter how large the cache is (unless it's == device size
:-)
So we need something a bit more involved, but not too complex. A fine
line...
--
Jens Axboe
next prev parent reply other threads:[~2008-10-11 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200810101904.m9AJ42Gq018897@hera.kernel.org>
2008-10-10 19:25 ` libata: set queue SSD flag for SSD devices Alan Cox
2008-10-10 20:05 ` Jens Axboe
2008-10-11 0:55 ` Arjan van de Ven
2008-10-11 6:36 ` Jens Axboe
2008-10-11 7:33 ` James Bottomley
2008-10-11 14:06 ` Jens Axboe [this message]
2008-10-11 15:44 ` James Bottomley
2008-10-11 16:04 ` Arjan van de Ven
2008-10-11 16:38 ` James Bottomley
2008-10-11 16:49 ` Arjan van de Ven
2008-10-11 17:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081011140600.GR19428@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).