linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: ide: Bug fixes and improvements in the disk head parking code
Date: Mon, 13 Oct 2008 21:04:38 +0200	[thread overview]
Message-ID: <200810132104.39673.bzolnier@gmail.com> (raw)
In-Reply-To: <87fxn3hw33.fsf@denkblock.local>

On Saturday 11 October 2008, Elias Oltmanns wrote:
> Fix a memory leak due to a missing blk_put_request() in
> issue_park_cmd(). Additionally, we should plug the queue when enqueueing
> the unpark request because there is no guarantee that the park timeout
> has not expired by then. Even though the chance for that to happen is
> very slim, the request might end up hanging in the queue until the next
> I/O operation is queued up. While at it, clean up the code a little:
> - make issue_park_cmd() a function of type void since nobody cares for
>   the return value anyway;
> - use blk_start_queueing() instead of __blk_run_queue() since we don't
>   have to worry about recursion;
> - remove a superfluous pointer deference in task_no_data_intr().
> 
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
> ---
> Feel free to merge with original patch if Linus hasn't pulled your tree
> yet.

done, thanks

      reply	other threads:[~2008-10-13 20:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11 17:37 ide: Bug fixes and improvements in the disk head parking code Elias Oltmanns
2008-10-13 19:04 ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810132104.39673.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=eo@nebensachen.de \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).