Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: jeff@redhat.com
Cc: linux-ide@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] stop gcc warning about uninitialized 'dev' in ata_scsi_scan_host
Date: Wed, 15 Oct 2008 17:25:05 -0600	[thread overview]
Message-ID: <20081015232505.GB9272@ldl.fc.hp.com> (raw)

Shuts up gcc-3.4.5-glibc-2.3.6 when it complains of:

drivers/ata/libata-scsi.c: In function `ata_scsi_scan_host':
drivers/ata/libata-scsi.c:3225: warning: 'dev' might be used
uninitialized in this function

Signed-off-by: Alex Chiang <achiang@hp.com>
---
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 5d312dc..4e27c68 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3222,7 +3222,7 @@ void ata_scsi_scan_host(struct ata_port *ap, int sync)
 	int tries = 5;
 	struct ata_device *last_failed_dev = NULL;
 	struct ata_link *link;
-	struct ata_device *dev;
+	struct ata_device *dev = NULL;
 
 	if (ap->flags & ATA_FLAG_DISABLED)
 		return;

             reply	other threads:[~2008-10-15 23:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 23:25 Alex Chiang [this message]
2008-10-16  2:11 ` [PATCH] stop gcc warning about uninitialized 'dev' in ata_scsi_scan_host Tejun Heo
2008-10-16  3:40   ` Alex Chiang
2008-10-16  3:54     ` Tejun Heo
2008-10-16  6:02       ` Elias Oltmanns
2008-10-16  6:08         ` Tejun Heo
2008-10-16  6:16     ` Adrian Bunk
2008-10-16 21:21       ` Alex Chiang
2008-10-16 21:22       ` Alex Chiang
2008-10-16 21:24         ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081015232505.GB9272@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=jeff@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox