linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scc_pata: kill unused variables
@ 2008-10-16 19:05 Sergei Shtylyov
  2008-10-16 19:40 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2008-10-16 19:05 UTC (permalink / raw)
  To: bzolnier; +Cc: linux-ide

Fix the "unused variable" warning in init_hwif_scc() caused by the commit
48c3c1072651922ed153bcf0a33ea82cf20df390 (ide: add struct ide_host (take 3)).
Moreover, remove the write-only variable 'dma_status_port' in init_setup_scc()
about which gcc gives no warning and which has been there from the very start...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
This patch is against the recent Linus' kernel...

 drivers/ide/pci/scc_pata.c |    4 ----
 1 files changed, 4 deletions(-)

Index: linux-2.6/drivers/ide/pci/scc_pata.c
===================================================================
--- linux-2.6.orig/drivers/ide/pci/scc_pata.c
+++ linux-2.6/drivers/ide/pci/scc_pata.c
@@ -617,7 +617,6 @@ static int __devinit init_setup_scc(stru
 	unsigned long intmask_port;
 	unsigned long mode_port;
 	unsigned long ecmode_port;
-	unsigned long dma_status_port;
 	u32 reg = 0;
 	struct scc_ports *ports;
 	int rc;
@@ -637,7 +636,6 @@ static int __devinit init_setup_scc(stru
 	intmask_port = dma_base + 0x010;
 	mode_port = ctl_base + 0x024;
 	ecmode_port = ctl_base + 0xf00;
-	dma_status_port = dma_base + 0x004;
 
 	/* controller initialization */
 	reg = 0;
@@ -843,8 +841,6 @@ static u8 scc_cable_detect(ide_hwif_t *h
 
 static void __devinit init_hwif_scc(ide_hwif_t *hwif)
 {
-	struct scc_ports *ports = ide_get_hwifdata(hwif);
-
 	/* PTERADD */
 	out_be32((void __iomem *)(hwif->dma_base + 0x018), hwif->dmatable_dma);
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scc_pata: kill unused variables
  2008-10-16 19:05 [PATCH] scc_pata: kill unused variables Sergei Shtylyov
@ 2008-10-16 19:40 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-10-16 19:40 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: linux-ide

On Thursday 16 October 2008, Sergei Shtylyov wrote:
> Fix the "unused variable" warning in init_hwif_scc() caused by the commit
> 48c3c1072651922ed153bcf0a33ea82cf20df390 (ide: add struct ide_host (take 3)).
> Moreover, remove the write-only variable 'dma_status_port' in init_setup_scc()
> about which gcc gives no warning and which has been there from the very start...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-16 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-16 19:05 [PATCH] scc_pata: kill unused variables Sergei Shtylyov
2008-10-16 19:40 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).