linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valerio Passini <valerio.passini@unicam.it>
To: petkovbb@gmail.com
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-ide@vger.kernel.org
Subject: Re: http://bugzilla.kernel.org/show_bug.cgi?id=11742
Date: Wed, 22 Oct 2008 16:45:22 +0200	[thread overview]
Message-ID: <200810221645.22289.valerio.passini@unicam.it> (raw)
In-Reply-To: <9ea470500810220427w30485f0fs5017c2da08fd1796@mail.gmail.com>


> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 13265a8..6943462 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1251,8 +1251,14 @@ static void cdrom_do_block_pc(ide_drive_t
> *drive, struct request *rq)
>  		 */
>  		alignment = queue_dma_alignment(q) | q->dma_pad_mask;
>  		if ((unsigned long)buf & alignment || rq->data_len & alignment
> -		    || object_is_on_stack(buf))
> +		    || object_is_on_stack(buf)) {
> +			printk(KERN_ERR "Disabling dma for ATA_PC, "
> +			       "queue_dma_alignment: 0x%x, q->dma_pad_mask: 0x%x,"
> +			       "buf: %p, rq->data_len: 0x%x, on_stack: %d\n",
> +			       queue_dma_alignment(q), q->dma_pad_mask, buf,
> +			       rq->data_len, object_is_on_stack(buf));
>  			drive->dma = 0;
> +		}
>  	}
>  }

Hi Boris, please send me patches already formatted to be applied by patch 
program, because the substitution of spaces with tabs and other indentation 
characters requires a lot of time and it has never worked (or explain me how 
to make it work :))

Anyhow, I have given a look to the patch compared to the original file. Is it 
possible to apply to plain 2.6.27 kernel? From a brief look, it is very 
different from 2.6.27 ide-cd.c file and maybe I need to download the 
development branch of the kernel with GIT to apply it or a more recent 
subversion like 2.6.27.2.

Waiting for you.

P.S: I have received messages from bugzilla, but I have subscribed to this 
mailing list on Fujita's suggestion just to ease communication. What do you 
prefer between bugzilla and linux-ide? 

  parent reply	other threads:[~2008-10-22 14:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-18 18:07 http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-20  2:20 ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 FUJITA Tomonori
2008-10-20  6:07   ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-21 23:57   ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 FUJITA Tomonori
2008-10-22  6:12     ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-22  6:50       ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 FUJITA Tomonori
2008-10-22 11:27         ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Boris Petkov
2008-10-22 13:30           ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Valerio Passini
2008-10-22 14:45           ` Valerio Passini [this message]
2008-10-22 15:57             ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Boris Petkov
2008-10-22 22:20               ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Valerio Passini
2008-10-23  6:09                 ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-23 13:53                   ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Valerio Passini
2008-10-22 20:15         ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Bartlomiej Zolnierkiewicz
2008-10-24  6:50           ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-25 12:58             ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Bartlomiej Zolnierkiewicz
2008-10-25 13:42               ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Sergei Shtylyov
2008-10-25 17:47                 ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-25 18:21                   ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Sergei Shtylyov
2008-10-25 18:27                     ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Sergei Shtylyov
2008-10-25 18:43                     ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-25 18:12               ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-26  8:38                 ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Valerio Passini
2008-10-26 14:58                   ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-26 20:01                     ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Valerio Passini
2008-10-27  6:15                       ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Borislav Petkov
2008-10-27 10:14                         ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Valerio Passini
2008-10-27 10:47                         ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Sergei Shtylyov
2008-10-27 10:55                           ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Boris Petkov
2008-10-27 11:15                             ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Sergei Shtylyov
2008-10-27 19:46                         ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 Bartlomiej Zolnierkiewicz
2008-10-27  5:46               ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 FUJITA Tomonori
2008-10-27  8:37                 ` http://bugzilla.kernel.org/show_bug.cgi?id=11742 FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810221645.22289.valerio.passini@unicam.it \
    --to=valerio.passini@unicam.it \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-ide@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).