From: Phil Sutter <n0-1@freewrt.org>
To: linux-ide@vger.kernel.org
Subject: Re: [PATCH] irq handler must disable the handled irq
Date: Mon, 27 Oct 2008 16:41:06 +0100 [thread overview]
Message-ID: <20081027154106.GA27227@nuty> (raw)
In-Reply-To: <20081027141509.2d0be2c7@lxorguk.ukuu.org.uk>
On Mon, Oct 27, 2008 at 02:15:09PM +0000, Alan Cox wrote:
> You can't call disable_irq in an IRQ handler. What are you actually
> trying to do ?
Well, what I'm trying to do is getting the driver to a working state.
But it seems like I don't know what I'm actually doing. :/
The symptom I discovered was rb532_pata_irq_handler() being called over
and over again, endlessly. Calling disable_irq() from within stopped
that, so I assumed it to be right (obviously the wrong direction for a
proof).
As the working driver for 2.6.19 I have here is not based on libata, I'm
not quite sure how much code is still required and where to hook it into
the libata subsystem.
Greetings, Phil
next prev parent reply other threads:[~2008-10-27 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 14:01 [PATCH] irq handler must disable the handled irq Phil Sutter
2008-10-27 14:15 ` Alan Cox
2008-10-27 15:41 ` Phil Sutter [this message]
2008-10-27 19:38 ` Bartlomiej Zolnierkiewicz
2008-10-27 20:51 ` Phil Sutter
2008-10-29 18:19 ` [PATCH] include old-style rb532 CompactFlash support Phil Sutter
2008-10-29 18:56 ` Phil Sutter
2008-10-29 19:25 ` Bartlomiej Zolnierkiewicz
2008-10-29 19:59 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027154106.GA27227@nuty \
--to=n0-1@freewrt.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).