Re: [PATCH 2/2] cmd64x: set IDE_HFLAG_SERIALIZE explictly for CMD646

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thursday 30 October 2008, Sergei Shtylyov wrote:
> Hello.
> 
> Bartlomiej Zolnierkiewicz wrote:
> 
> >>>>>>> * Set IDE_HFLAG_SERIALIZE explictly for CMD646.
> >>>>>>>           
> >>>>>>>               
> >>>>>>  Was that some kernel.org bug that this is fixing?
> >>>>>>         
> >>>>>>             
> >>>>> Nope (AFAIK).
> >>>>>       
> >>>>>           
> >>>>     User report then?
> >>>>     
> >>>>         
> >>> Nope as far as my inbox tells me.
> >>>   
> >>>       
> >>    Then whar's the reason? :-)
> >>     
> >
> > From the patch description:
> >
> > 	* Set IDE_HFLAG_SERIALIZE explictly for CMD646.
> >
> > 	* Remove no longer needed ide_cmd646 chipset type (which has
> > 	  a nice side-effect of fixing handling of unexpected IRQs).
> >
> > The latter is possible because of the former
> > (see ide-probe.c::init_irq() for details).
> >   
> 
>    Ah, got it at last. But I doubt that 646 *really* needs serialization...

I remember getting bugreport which supposedly was fixed by commit
deffca117b90dadec395c0cf3ee816de27dfe2fd (but it could also be that
it was something else in reality or that it just hide some other
bug that we fixed in the meantime).

We would need somebody with the hardware to verify it.