From: Jens Axboe <jens.axboe@oracle.com>
To: petkovbb@gmail.com
Cc: Tejun Heo <tj@kernel.org>,
bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Subject: [PATCH] block: fix __blkdev_get() for removable devices
Date: Wed, 5 Nov 2008 10:19:22 +0100 [thread overview]
Message-ID: <20081105091921.GC21867@kernel.dk> (raw)
In-Reply-To: <20081105090449.GA9269@gollum.tnic>
On Wed, Nov 05 2008, Borislav Petkov wrote:
> On Tue, Nov 04, 2008 at 01:16:07PM +0900, Tejun Heo wrote:
> > Commit 0762b8bde9729f10f8e6249809660ff2ec3ad735 moved disk_get_part()
> > in front of recursive get on the whole disk, which caused removable
> > devices to try disk_get_part() before rescanning after a new media is
> > inserted, which might fail legit open attempts or give the old
> > partition.
> >
> > This patch fixes the problem by moving disk_get_part() after
> > __blkdev_get() on the whole disk.
> >
> > This problem was spotted by Borislav Petkov.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: <Borislav Petkov> petkovbb@googlemail.com
> > ---
> > Borislav, can you please verify this patch? Thanks.
>
> Yep, it works. Thanks.
>
> Tested-by: Borislav Petkov <petkovbb@gmail.com>
I merged it and added your tested-by.
--
Jens Axboe
prev parent reply other threads:[~2008-11-05 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 7:13 [RFC PATCH] ide-floppy partitions Borislav Petkov
2008-10-29 7:42 ` [PATCH] ide-gd: re-get floppy capacity on revalidate Borislav Petkov
2008-10-29 19:22 ` Bartlomiej Zolnierkiewicz
2008-11-01 20:14 ` [RFC PATCH] ide-floppy partitions Borislav Petkov
2008-11-03 15:37 ` Tejun Heo
2008-11-03 17:56 ` Borislav Petkov
2008-11-04 4:16 ` Subject: [PATCH] block: fix __blkdev_get() for removable devices Tejun Heo
2008-11-05 9:04 ` Borislav Petkov
2008-11-05 9:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081105091921.GC21867@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).