From: Borislav Petkov <petkovbb@googlemail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Remy LABENE <remy.labene@free.fr>
Subject: Re: [PATCH] amd74xx: workaround unreliable AltStatus register for nVidia controllers
Date: Sat, 22 Nov 2008 12:33:42 +0100 [thread overview]
Message-ID: <20081122113342.GA8593@gollum.tnic> (raw)
In-Reply-To: <200811212238.51161.bzolnier@gmail.com>
On Fri, Nov 21, 2008 at 10:38:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
> It seems that on some nVidia controllers using AltStatus register
> can be unreliable so default to Status register if the PCI device
> is in Compatibility Mode. In order to achieve this:
>
> * Add ide_pci_is_in_compatibility_mode() inline helper to <linux/ide.h>.
>
> * Add IDE_HFLAG_BROKEN_ALTSTATUS host flag and set it in amd74xx host
> driver for nVidia controllers in Compatibility Mode.
>
> * Teach actual_try_to_identify() and drive_is_ready() about the new flag.
>
> This fixes the regression caused by removal of CONFIG_IDEPCI_SHARE_IRQ
> config option in 2.6.25 and using AltStatus register unconditionally when
> available (kernel.org bug #11659). [ Moreover for CONFIG_IDEPCI_SHARE_IRQ=y
> (which is what most distributions/people use) it never worked correctly. ]
Looks good.
Acked-by: Borislav Petkov <petkovbb@gmail.com>
>
> Thanks to Remy LABENE for help with debugging the problem.
>
> More info at:
> http://bugzilla.kernel.org/show_bug.cgi?id=11659
Bugzilla entry can be closed now.
[.. ]
--
Regards/Gruss,
Boris.
prev parent reply other threads:[~2008-11-22 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 21:38 [PATCH] amd74xx: workaround unreliable AltStatus register for nVidia controllers Bartlomiej Zolnierkiewicz
2008-11-22 11:33 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122113342.GA8593@gollum.tnic \
--to=petkovbb@googlemail.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=remy.labene@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox