From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Elias Oltmanns <eo@nebensachen.de>
Subject: Re: [PATCH 2/3] ide: add ide_[un]lock_hwgroup() helpers
Date: Sun, 14 Dec 2008 00:15:51 +0100 [thread overview]
Message-ID: <200812140015.51978.bzolnier@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0811190236550.24738@zirkon.biophys.uni-duesseldorf.de>
[ Sorry for the late reply. ]
On Wednesday 19 November 2008, Michael Schmitz wrote:
> > - while (!hwgroup->busy) {
> > - hwgroup->busy = 1;
> > - /* for atari only */
> > - ide_get_lock(ide_intr, hwgroup);
> > + while (!ide_lock_hwgroup(hwgroup)) {
>
> Something I've run into while working on the locking stuff: what happens if the
> above ide_lock_hwgroup(hwgroup) sleeps for long enough to trigger the request
> timer?
AFAICS this happens before the hwgroup timeout timer is armed and IDE is not
using block layer request timers yet so we should be fine here..
Thanks,
Bart
next prev parent reply other threads:[~2008-12-13 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 20:16 [PATCH 2/3] ide: add ide_[un]lock_hwgroup() helpers Bartlomiej Zolnierkiewicz
2008-11-19 2:33 ` Michael Schmitz
2008-12-13 23:15 ` Bartlomiej Zolnierkiewicz [this message]
2008-12-13 23:52 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812140015.51978.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=eo@nebensachen.de \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schmitz@biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).