From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] ide: update ide_unregister() documentation
Date: Tue, 16 Dec 2008 20:31:37 +0100 [thread overview]
Message-ID: <20081216193137.3959.70339.sendpatchset@localhost.localdomain> (raw)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide: update ide_unregister() documentation
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
just a couple of cleanups, should be applied on a top of Sunday's patchset
[ http://marc.info/?l=linux-kernel&m=122921159918716&w=2 ]
drivers/ide/ide.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
Index: b/drivers/ide/ide.c
===================================================================
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -155,22 +155,14 @@ EXPORT_SYMBOL_GPL(ide_port_unregister_de
* ide_unregister - free an IDE interface
* @hwif: IDE interface
*
- * Perform the final unregister of an IDE interface. At the moment
- * we don't refcount interfaces so this will also get split up.
+ * Perform the final unregister of an IDE interface.
*
* Locking:
- * The caller must not hold the IDE locks
- * The drive present/vanishing is not yet properly locked
- * Take care with the callbacks. These have been split to avoid
- * deadlocking the IDE layer. The shutdown callback is called
- * before we take the lock and free resources. It is up to the
- * caller to be sure there is no pending I/O here, and that
- * the interface will not be reopened (present/vanishing locking
- * isn't yet done BTW). After we commit to the final kill we
- * call the cleanup callback with the ide locks held.
+ * The caller must not hold the IDE locks.
*
- * Unregister restores the hwif structures to the default state.
- * This is raving bonkers.
+ * It is up to the caller to be sure there is no pending I/O here,
+ * and that the interface will not be reopened (present/vanishing
+ * locking isn't yet done BTW).
*/
void ide_unregister(ide_hwif_t *hwif)
next reply other threads:[~2008-12-16 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 19:31 Bartlomiej Zolnierkiewicz [this message]
2008-12-16 19:31 ` [PATCH 2/9] ide: move ide_init_port_data() and friends to ide-probe.c Bartlomiej Zolnierkiewicz
2008-12-16 19:31 ` [PATCH 3/9] ide: remove HWIF() macro Bartlomiej Zolnierkiewicz
2008-12-16 19:31 ` [PATCH 4/9] ide: remove local_irq_set() macro Bartlomiej Zolnierkiewicz
2008-12-16 19:32 ` [PATCH 5/9] ide: remove ide_pci_enablebit_t typedef Bartlomiej Zolnierkiewicz
2008-12-19 11:58 ` Sergei Shtylyov
2008-12-16 19:32 ` [PATCH 6/9] ide: remove 'byte' typedef Bartlomiej Zolnierkiewicz
2008-12-19 11:54 ` Sergei Shtylyov
2008-12-16 19:32 ` [PATCH 7/9] ide: remove ide_driver_t typedef Bartlomiej Zolnierkiewicz
2008-12-16 19:32 ` [PATCH 8/9] ide: unexport ide_wait_not_busy() Bartlomiej Zolnierkiewicz
2008-12-16 19:32 ` [PATCH 9/9] ide: remove ->error method from struct ide_driver Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216193137.3959.70339.sendpatchset@localhost.localdomain \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).