From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Jeff Garzik <jeff@garzik.org>,
Mario Schwalbe <schwalbe@inf.tu-dresden.de>,
linux-kernel@vger.kernel.org,
Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ide: Fix ata_id_has_dword_io to return DWORD I/O support properly
Date: Fri, 19 Dec 2008 20:30:34 +0100 [thread overview]
Message-ID: <200812192030.34554.bzolnier@gmail.com> (raw)
In-Reply-To: <20081219105013.0e43c364@lxorguk.ukuu.org.uk>
On Friday 19 December 2008, Alan Cox wrote:
> > Sure, we can always improve things further later. However Mario's patch
> > is _definitely_ an improvement over the _current_ code. Don't you agree?
>
> No actually I don't. The current head dev code checks ATA > 7 as the
> indicator that this bit is used for treacherous computing. That means the
> behaviour for all the older drives is clearly back compatible with old
> Linux behaviour.
>
> Doing it that way around means we don't have any worries about changing
> existing behaviours.
Please try to verify old Linux behaviour compatiblity statement with
some ATA-[2..7] devices... They have old ATA-1 bit set to _zero_...
Mario: I don't have anymore time to spend on fixing libata problems so
I'll be leaving ata_id_has_dword_io() issues up to libata maintainers,
sorry for inconvenience!
Thanks,
Bart
next prev parent reply other threads:[~2008-12-19 19:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <494A5BBF.8000807@inf.tu-dresden.de>
2008-12-18 17:08 ` [PATCH] ide: Fix ata_id_has_dword_io to return DWORD I/O support properly Jeff Garzik
2008-12-18 17:24 ` Sergei Shtylyov
2008-12-18 20:42 ` Bartlomiej Zolnierkiewicz
2008-12-18 22:40 ` Alan Cox
2008-12-18 23:13 ` Bartlomiej Zolnierkiewicz
2008-12-19 10:50 ` Alan Cox
2008-12-19 19:30 ` Bartlomiej Zolnierkiewicz [this message]
2008-12-20 0:10 ` Alan Cox
2008-12-19 11:31 ` Sergei Shtylyov
2008-12-19 11:34 ` Sergei Shtylyov
2008-12-18 18:10 ` Alan Cox
2008-12-20 1:58 ` Robert Hancock
2008-12-20 13:25 ` Sergei Shtylyov
2008-12-22 20:16 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812192030.34554.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwalbe@inf.tu-dresden.de \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).