Re: [PATCH 0/8] ide-cd: first conversion batch

Bartlomiej Zolnierkiewicz
2008-12-21T20:57:50Z

Hi,

On Saturday 20 December 2008, Borislav Petkov wrote:
> Hi,
>
> On Fri, Dec 19, 2008 at 09:15:40PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> [.. ]
>
> > Yes, we don't want to move them over. In worst case we can add
> > ide_handler_t *__old_pc_handler to ide_drive_t and set it in ide-cd
> > (an acceptable hack this time) but there might be better options.
>
> Ok, here's the final patch moving ide-cd to the services of
> ide_(issue|transfer)_pc. The only change in functionality is that we

I merged the patchset (with 2 very minor fixups) but I think that this
one still needs some small preparatory changes first.

[ BTW I also merged outstanding ide patches. Not many ide-{atapi,cd}
changes in them though. Thus if you prefer you may as well send me
patches based on the old tree and let me handle potential rejects. ]

> don't do cdrom_decode_status for DRQ_INTERRUPT devices but this is
> probably not that relevant anymore since we busy-wait for DRQ to get set
> through ide_wait_stat, as we talked about it before - it being a bugfix for
> all atapi devices. If there's still interest for that (and I think it

Yes, this change is OK but for bisectability reasons it would be better
to do it in pre-patch (which would fix ide-cd.c accordingly).

[ The other changes in functionality are small and acceptable for this
patch (i.e. ide_wait_stat() prints error message now) except the change
of the ordering between ->dma_start and ->output_data calls -- which
also seems to deserve patch on its own. ]

Otherwise it all looks fine and Big Thanks for working on this!