Re: [PATCH #upstream-fixes] ata_piix: save, use saved and restore IOCFG

[Andreas Mohr <andi@lisas.de>]

Hi,

On Fri, Jan 02, 2009 at 12:04:48PM +0900, Tejun Heo wrote:
> Certain ACPI implementations mess up IOCFG on _STM making libata
> detect cable type incorrectly after a suspend/resume cycle.  This
> patch makes ata_piix save IOCFG on attach, use the saved value for
> things which aren't dynamic and restore it on detach so that the next
> driver also gets the BIOS initialized value.
> 
> This patch contains the following changes.
> 
> * makes ich_pata_cable_detect() use saved_iocfg.
> 
> * make piix_iocfg_bit18_quirk() take @host and use saved_iocfg.
> 
> * hpriv allocation moved upwards to save iocfg before doing anything
>   else.
> 
> This fixes bz#11879.  Andreas Mohr reported and diagnosed the problem.

I'm mighty unhappy ;-)

First, I still think prime cause was a weak disk implementation of Word 93
and not BIOS ACPI handling itself (bug #12202 is a PATA SSD, too!).
(unless one thinks that BIOS should know about SSD variants of PATA
and actively do special-case them itself)
Second, you've been keeping silent about the duplicate processing
for too long (I didn't know about it at all until marked duplicate),
thus nobody else could derive any hard facts from the doubled information.
Third, it was not just me who reported it, Carl Michal did >= 10 reports
in his bug.
Fourth, "bz#11879" may seem a precise indication, but when writing this
within Bugzilla instead of a plain "bug #11879", you probably won't have it
hyperlinked, thus I'd always prefer the usual writing. </nitpick>


Patch seems fine to me, thanks a helluva lot for your hard work!
(probably will test, later)

> Signed-off-by: Tejun Heo <tj@kernel.org>

Acked-by: Andreas Mohr <andi@lisas.de>