linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brandon Philips <brandon@ifup.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
	Shawn Lin <shawn@dmp.com.tw>
Subject: [PATCH] it821x.c: use dev->revision instead of pci_read_config_byte
Date: Mon, 5 Jan 2009 11:10:06 -0800	[thread overview]
Message-ID: <20090105191006.GD22062@jenkins.ifup.org> (raw)
In-Reply-To: <20090105171104.5db48c74@lxorguk.ukuu.org.uk>

Minor cleanup.

Signed-off-by: Brandon Philips <bphilips@suse.de>

---
 drivers/ide/it821x.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6/drivers/ide/it821x.c
===================================================================
--- linux-2.6.orig/drivers/ide/it821x.c
+++ linux-2.6/drivers/ide/it821x.c
@@ -563,8 +563,7 @@ static void __devinit init_hwif_it821x(i
 	 *	this is necessary.
 	 */
 
-	pci_read_config_byte(dev, 0x08, &conf);
-	if (conf == 0x10) {
+	if (dev->revision == 0x10) {
 		idev->timing10 = 1;
 		hwif->host_flags |= IDE_HFLAG_NO_ATAPI_DMA;
 		if (idev->smart == 0)

  parent reply	other threads:[~2009-01-05 19:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-05 16:58 it821x: Add ultra_mask quirk for Vortex86SX Brandon Philips
2009-01-05 17:11 ` Alan Cox
2009-01-05 19:08   ` [PATCH v2] " Brandon Philips
2009-01-07 20:21     ` Bartlomiej Zolnierkiewicz
2009-01-05 19:10   ` Brandon Philips [this message]
2009-01-07 20:22     ` [PATCH] it821x.c: use dev->revision instead of pci_read_config_byte Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090105191006.GD22062@jenkins.ifup.org \
    --to=brandon@ifup.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=shawn@dmp.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).