From: Arjan van de Ven <arjan@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
mingo@elte.hu, akpm@linux-foundation.org,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: [PATCH 6/6] fastboot: Make libata initialization even more async
Date: Mon, 5 Jan 2009 20:13:44 -0800 [thread overview]
Message-ID: <20090105201344.33cf1213@infradead.org> (raw)
In-Reply-To: <20090105200959.04a626ac@infradead.org>
>From d9edec388ac06b74f190ed9ea929158003b915ee Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Mon, 5 Jan 2009 15:07:07 -0800
Subject: [PATCH] fastboot: Make libata initialization even more async
As suggested by Linus: Don't do the libata init in 2 separate
steps with a global sync inbetween, but do it as one async step,
with a local sync before registering the device.
This cuts the boottime on my machine with 2 sata controllers down
significantly, and it seems to work. Would be nice if the libata
folks take a good look at this patch though..
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
drivers/ata/libata-core.c | 16 +++++++---------
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index fe2c208..5d4f7e5 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5951,6 +5951,12 @@ void async_port_probe(void *data, async_cookie_t cookie)
*/
}
}
+
+ /* in order to keep device order, we need to synchronize at this point */
+ async_synchronize_cookie(cookie);
+
+ ata_scsi_scan_host(ap, 1);
+
}
/**
* ata_host_register - register initialized ATA host
@@ -6033,15 +6039,7 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
struct ata_port *ap = host->ports[i];
async_schedule(async_port_probe, ap);
}
- async_synchronize_full();
- /* probes are done, now scan each port's disk(s) */
- DPRINTK("host probe begin\n");
- for (i = 0; i < host->n_ports; i++) {
- struct ata_port *ap = host->ports[i];
-
- ata_scsi_scan_host(ap, 1);
- }
- DPRINTK("host probe end\n");
+ DPRINTK("probe end\n");
return 0;
}
--
1.6.0.6
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
prev parent reply other threads:[~2009-01-06 4:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090105200959.04a626ac@infradead.org>
2009-01-06 4:10 ` [PATCH 1/6] fastboot: Asynchronous function calls to speed up kernel boot Arjan van de Ven
2009-01-06 4:25 ` Andrew Morton
2009-01-06 4:37 ` Arjan van de Ven
2009-01-06 13:57 ` Arjan van de Ven
2009-01-14 5:32 ` Zhang Rui
2009-01-14 9:04 ` Arjan van de Ven
2009-01-15 5:55 ` Zhang Rui
2009-01-06 4:11 ` [PATCH 2/6] fastboot: make scsi probes asynchronous Arjan van de Ven
2009-01-09 18:17 ` Mark Lord
2009-01-06 4:12 ` [PATCH 3/6] fastboot: make the libata port scan asynchronous Arjan van de Ven
2009-01-07 9:12 ` Bert Wesarg
2009-01-06 4:12 ` [PATCH 4/6] fastboot: make ACPI bus drivers probe asynchronous Arjan van de Ven
2009-01-07 14:12 ` Yong Wang
2009-01-07 17:25 ` Arjan van de Ven
2009-01-06 4:13 ` [PATCH 5/6] bootchart: improve output Arjan van de Ven
2009-01-06 4:13 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105201344.33cf1213@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).