Re: [PATCH] ide: can't use SSD/non-rotational queue flag for all CFA devices

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Monday 05 January 2009, Sergei Shtylyov wrote:
> Hello.
> 
> Bartlomiej Zolnierkiewicz wrote:
> 
> > Some rotating disks also present themselves as CFA devices.
> >
> > Reported-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >   
> 
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> > Index: b/drivers/ide/ide-disk.c
> > ===================================================================
> > --- a/drivers/ide/ide-disk.c
> > +++ b/drivers/ide/ide-disk.c
> > @@ -633,7 +633,7 @@ static void ide_disk_setup(ide_drive_t *
> >  	printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name,
> >  		q->max_sectors / 2);
> >  
> > -	if (ata_id_is_ssd(id) || ata_id_is_cfa(id))
> > +	if (ata_id_is_ssd(id))
> >  		queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
> >  
> >  	/* calculate drive capacity, and select LBA if possible */
> > N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±‰×¢žØ^n‡r¡ö¦zË\x1a�ëh™¨è­Ú&¢ø\x1e®G«�éh®\x03(­éšŽŠÝ¢j"�ú\x1a¶^[m§ÿï�êäz¹Þ–Šàþf£¢·hšˆ§~ˆmml==
> 
> Hm, why your Kmail base64-encodes plain English messages and adds this 
> kind of binary crap?

Huh?  Haven't you heard about the latest trend of inserting hidden data
into your mails?  All the cool dudes are doing it nowadays... 8-)

Now seriously... I would love to know the answer to your question myself.

[ After distro upgrade I noticed that new KMail's version started adding
  a non-ascii character at the end of inserted file (when composing message
  and using "Message" -> "Insert File").  The workaround is to remove the
  character manually but I sometimes forget about it... ]

Thanks,
Bart