From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()
Date: Sat, 10 Jan 2009 14:27:06 +0100
Message-ID: <200901101427.06645.borntraeger@de.ibm.com>
References: <200901091334.55823.borntraeger@de.ibm.com> <200901101404.39139.borntraeger@de.ibm.com> <49689F19.7030203@garzik.org>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <linux-ide-owner@vger.kernel.org>
Received: from mtagate3.uk.ibm.com ([195.212.29.136]:48246 "EHLO
	mtagate3.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750853AbZAJN1K (ORCPT
	<rfc822;linux-ide@vger.kernel.org>); Sat, 10 Jan 2009 08:27:10 -0500
In-Reply-To: <49689F19.7030203@garzik.org>
Content-Disposition: inline
Sender: linux-ide-owner@vger.kernel.org
List-Id: linux-ide@vger.kernel.org
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@redhat.com>, lkml <linux-kernel@vger.kernel.org>

Am Samstag 10 Januar 2009 schrieb Jeff Garzik:
> Christian Borntraeger wrote:
> > Am Samstag 10 Januar 2009 schrieb Alan Cox:
> >>>    That's the typical REQUEST SENSE command with 18-byte data length.
> >> Which means something has become horribly broken in the core libata 
stack.
> >> An 18 byte inquiry would have 18 bytes as the *last* sg element. That
> >> would therefore not trigger the WARN_ON. Someone has passed an sg list
> >> that isn't properly terminated perhaps ?
> >>
> >> I wonder if the pad code broke this.
> > 
> > I just checked 2.6.28 + PIO32 patch. Its also broken. Whatever caused this 
> > problem did it a while ago.
> 
> Just to be clear, you mean:
> 
> 2.6.28 is OK
> 2.6.28 + PIO32 is broken
> 
> Correct?

Yes.