linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving
@ 2009-01-10 17:20 Atsushi Nemoto
  2009-01-10 17:25 ` Sergei Shtylyov
  0 siblings, 1 reply; 4+ messages in thread
From: Atsushi Nemoto @ 2009-01-10 17:20 UTC (permalink / raw)
  To: linux-ide; +Cc: Bartlomiej Zolnierkiewicz, sshtylyov

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
 drivers/ide/tx4938ide.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
index b4ef218..d909534 100644
--- a/drivers/ide/tx4938ide.c
+++ b/drivers/ide/tx4938ide.c
@@ -202,7 +202,6 @@ static const struct ide_tp_ops tx4938ide_tp_ops = {
 	.exec_command		= ide_exec_command,
 	.read_status		= ide_read_status,
 	.read_altstatus		= ide_read_altstatus,
-	.read_sff_dma_status	= ide_read_sff_dma_status,
 
 	.set_irq		= ide_set_irq,
 
-- 
1.5.6.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving
  2009-01-10 17:20 [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving Atsushi Nemoto
@ 2009-01-10 17:25 ` Sergei Shtylyov
  2009-01-11 16:31   ` Bartlomiej Zolnierkiewicz
  2009-01-15 13:52   ` Sergei Shtylyov
  0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2009-01-10 17:25 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-ide, Bartlomiej Zolnierkiewicz

Atsushi Nemoto wrote:

> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
> index b4ef218..d909534 100644
> --- a/drivers/ide/tx4938ide.c
> +++ b/drivers/ide/tx4938ide.c
> @@ -202,7 +202,6 @@ static const struct ide_tp_ops tx4938ide_tp_ops = {
>  	.exec_command		= ide_exec_command,
>  	.read_status		= ide_read_status,
>  	.read_altstatus		= ide_read_altstatus,
> -	.read_sff_dma_status	= ide_read_sff_dma_status,
>  
>  	.set_irq		= ide_set_irq,
>  

    Oops. Don;t know how I managed to miss this one...

MBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving
  2009-01-10 17:25 ` Sergei Shtylyov
@ 2009-01-11 16:31   ` Bartlomiej Zolnierkiewicz
  2009-01-15 13:52   ` Sergei Shtylyov
  1 sibling, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-01-11 16:31 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: Atsushi Nemoto, linux-ide

On Saturday 10 January 2009, Sergei Shtylyov wrote:
> Atsushi Nemoto wrote:
> 
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving
  2009-01-10 17:25 ` Sergei Shtylyov
  2009-01-11 16:31   ` Bartlomiej Zolnierkiewicz
@ 2009-01-15 13:52   ` Sergei Shtylyov
  1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2009-01-15 13:52 UTC (permalink / raw)
  To: Atsushi Nemoto, Bartlomiej Zolnierkiewicz; +Cc: linux-ide

Hello, I wrote:

>> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

>> diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
>> index b4ef218..d909534 100644
>> --- a/drivers/ide/tx4938ide.c
>> +++ b/drivers/ide/tx4938ide.c
>> @@ -202,7 +202,6 @@ static const struct ide_tp_ops tx4938ide_tp_ops = {
>>      .exec_command        = ide_exec_command,
>>      .read_status        = ide_read_status,
>>      .read_altstatus        = ide_read_altstatus,
>> -    .read_sff_dma_status    = ide_read_sff_dma_status,
>>  
>>      .set_irq        = ide_set_irq,
>>  
> 
> 
>    Oops. Don;t know how I managed to miss this one...

    Ah, I know how: this driver was added after I created my patch, and I 
didn't re-check for the missing pieces several months later, when preparing 
the patch for submission. :-/

MBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-01-15 13:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-10 17:20 [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving Atsushi Nemoto
2009-01-10 17:25 ` Sergei Shtylyov
2009-01-11 16:31   ` Bartlomiej Zolnierkiewicz
2009-01-15 13:52   ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).