From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: IDE: fix sparse signed-ness errors with host->host_busy
Date: Wed, 14 Jan 2009 18:21:11 +0100 [thread overview]
Message-ID: <200901141821.11834.bzolnier@gmail.com> (raw)
In-Reply-To: <20090113172808.616407105@fluff.org.uk>
On Tuesday 13 January 2009, Ben Dooks wrote:
> The host_busy field in struct ide_host defaults to a
> signed-long, where most arch's test_and_set_bit_*
> macros use an unsigned long.
>
> Change to using an unsigned long, which on ARM removes
> the following sparse errors:
>
> drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:681:8: expected unsigned long volatile *p
> drivers/ide/ide-io.c:681:8: got long volatile *<noident>
> drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:681:8: expected unsigned long volatile *p
> drivers/ide/ide-io.c:681:8: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
thanks, applied
prev parent reply other threads:[~2009-01-14 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 17:28 IDE: fix sparse signed-ness errors with host->host_busy Ben Dooks
2009-01-14 17:21 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901141821.11834.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).