* IDE: fix sparse signed-ness errors with host->host_busy
@ 2009-01-13 17:28 Ben Dooks
2009-01-14 17:21 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2009-01-13 17:28 UTC (permalink / raw)
To: bzolnier, linux-ide; +Cc: Ben Dooks
[-- Attachment #1: simtec/sparse-fix/ide-fix-host-busy.patch --]
[-- Type: text/plain, Size: 2992 bytes --]
The host_busy field in struct ide_host defaults to a
signed-long, where most arch's test_and_set_bit_*
macros use an unsigned long.
Change to using an unsigned long, which on ARM removes
the following sparse errors:
drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:681:8: expected unsigned long volatile *p
drivers/ide/ide-io.c:681:8: got long volatile *<noident>
drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:681:8: expected unsigned long volatile *p
drivers/ide/ide-io.c:681:8: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
drivers/ide/ide-io.c:695:3: got long volatile *<noident>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux.git/include/linux/ide.h
===================================================================
--- linux.git.orig/include/linux/ide.h 2009-01-09 14:38:45.000000000 +0000
+++ linux.git/include/linux/ide.h 2009-01-09 14:39:03.000000000 +0000
@@ -871,7 +871,7 @@ struct ide_host {
ide_hwif_t *cur_port; /* for hosts requiring serialization */
/* used for hosts requiring serialization */
- volatile long host_busy;
+ volatile unsigned long host_busy;
};
#define IDE_HOST_BUSY 0
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: IDE: fix sparse signed-ness errors with host->host_busy
2009-01-13 17:28 IDE: fix sparse signed-ness errors with host->host_busy Ben Dooks
@ 2009-01-14 17:21 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-01-14 17:21 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-ide
On Tuesday 13 January 2009, Ben Dooks wrote:
> The host_busy field in struct ide_host defaults to a
> signed-long, where most arch's test_and_set_bit_*
> macros use an unsigned long.
>
> Change to using an unsigned long, which on ARM removes
> the following sparse errors:
>
> drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:681:8: expected unsigned long volatile *p
> drivers/ide/ide-io.c:681:8: got long volatile *<noident>
> drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:681:8: expected unsigned long volatile *p
> drivers/ide/ide-io.c:681:8: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
> drivers/ide/ide-io.c:695:3: warning: incorrect type in argument 2 (different signedness)
> drivers/ide/ide-io.c:695:3: expected unsigned long volatile *p
> drivers/ide/ide-io.c:695:3: got long volatile *<noident>
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
thanks, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-14 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 17:28 IDE: fix sparse signed-ness errors with host->host_busy Ben Dooks
2009-01-14 17:21 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).