From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] ide: move ->rqsize init from init_irq() to ide_init_port()
Date: Wed, 14 Jan 2009 18:25:21 +0100 [thread overview]
Message-ID: <200901141825.21896.bzolnier@gmail.com> (raw)
In-Reply-To: <496A5D64.6030007@ru.mvista.com>
On Sunday 11 January 2009, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >
>
> > Index: b/drivers/ide/ide-probe.c
> > ===================================================================
> > --- a/drivers/ide/ide-probe.c
> > +++ b/drivers/ide/ide-probe.c
> >
> [...]
> > @@ -1242,6 +1234,13 @@ static void ide_init_port(ide_hwif_t *hw
> >
> > if (d->max_sectors)
> > hwif->rqsize = d->max_sectors;
> > + else {
> > + if ((hwif->host_flags & IDE_HFLAG_NO_LBA48) ||
> > + (hwif->host_flags & IDE_HFLAG_NO_LBA48_DMA))
> >
>
> Er, why not:
>
> if (hwif->host_flags &
> (IDE_HFLAG_NO_LBA48 | IDE_HFLAG_NO_LBA48_DMA))
IMO it is harder to read
next prev parent reply other threads:[~2009-01-14 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 18:35 [PATCH 1/9] via82cxxx: fix cable warning message Bartlomiej Zolnierkiewicz
2009-01-06 18:35 ` [PATCH 2/9] sl82c105: remove dead code Bartlomiej Zolnierkiewicz
2009-01-11 21:14 ` Sergei Shtylyov
2009-01-12 17:59 ` Bartlomiej Zolnierkiewicz
2009-01-06 18:35 ` [PATCH 4/9] ide: fix IDE_DFLAG_NO_IO_32BIT handling Bartlomiej Zolnierkiewicz
2009-01-06 18:35 ` [PATCH 5/9] ide: move ide_pktcmd_tf_load() to ide-atapi.c Bartlomiej Zolnierkiewicz
2009-01-11 21:18 ` Sergei Shtylyov
2009-01-06 18:35 ` [PATCH 6/9] ide: no need to touch local IRQs in ide_probe_port() Bartlomiej Zolnierkiewicz
2009-01-06 18:36 ` [PATCH 7/9] ide: move ->rqsize init from init_irq() to ide_init_port() Bartlomiej Zolnierkiewicz
2009-01-11 20:58 ` Sergei Shtylyov
2009-01-14 17:25 ` Bartlomiej Zolnierkiewicz [this message]
2009-01-22 14:52 ` Bartlomiej Zolnierkiewicz
2009-01-06 18:36 ` [PATCH 8/9] ide: move ->lock and ->timer init from init_irq() to ide_init_port_data() Bartlomiej Zolnierkiewicz
2009-01-06 18:36 ` [PATCH 9/9] ide: init_irq() doesn't need to hold ide_cfg_mtx Bartlomiej Zolnierkiewicz
2009-01-11 21:17 ` [PATCH 1/9] via82cxxx: fix cable warning message Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901141825.21896.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).