From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/6] ide: fix comments in ide_config_drive_speed()
Date: Mon, 19 Jan 2009 14:03:36 +0100 [thread overview]
Message-ID: <20090119130336.24745.7606.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090119130309.24745.40877.sendpatchset@localhost.localdomain>
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide: fix comments in ide_config_drive_speed()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-iops.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
Index: b/drivers/ide/ide-iops.c
===================================================================
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -369,18 +369,15 @@ int ide_config_drive_speed(ide_drive_t *
* but for some reason these don't work at
* this point (lost interrupt).
*/
- /*
- * Select the drive, and issue the SETFEATURES command
- */
- disable_irq_nosync(hwif->irq);
-
+
/*
* FIXME: we race against the running IRQ here if
* this is called from non IRQ context. If we use
* disable_irq() we hang on the error path. Work
* is needed.
*/
-
+ disable_irq_nosync(hwif->irq);
+
udelay(1);
SELECT_DRIVE(drive);
SELECT_MASK(drive, 1);
next prev parent reply other threads:[~2009-01-19 13:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 13:03 [PATCH 0/6] ide: more core code housekeeping Bartlomiej Zolnierkiewicz
2009-01-19 13:03 ` [PATCH 1/6] ide: move ide_read_bcount_and_ireason() to ide-atapi.c Bartlomiej Zolnierkiewicz
2009-01-19 13:03 ` [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c Bartlomiej Zolnierkiewicz
2009-01-19 14:17 ` Sergei Shtylyov
2009-01-19 14:23 ` Bartlomiej Zolnierkiewicz
2009-01-19 14:29 ` Sergei Shtylyov
2009-01-19 14:31 ` Sergei Shtylyov
2009-01-19 14:35 ` Bartlomiej Zolnierkiewicz
2009-01-19 17:37 ` Alan Cox
2009-01-19 18:02 ` Sergei Shtylyov
2009-01-19 18:36 ` Alan Cox
2009-01-19 18:46 ` Sergei Shtylyov
2009-01-19 18:49 ` Alan Cox
2009-01-19 19:04 ` Sergei Shtylyov
2009-01-19 21:31 ` Alan Cox
2009-01-19 21:48 ` Sergei Shtylyov
2009-01-19 22:37 ` Sergei Shtylyov
2009-01-19 19:12 ` Bartlomiej Zolnierkiewicz
2009-01-19 19:53 ` Sergei Shtylyov
2009-01-19 16:39 ` Sergei Shtylyov
2009-01-19 13:03 ` [PATCH 3/6] ide: fix printk() levels in [atapi_]reset_pollfunc() Bartlomiej Zolnierkiewicz
2009-01-19 14:28 ` Sergei Shtylyov
2009-01-19 13:03 ` Bartlomiej Zolnierkiewicz [this message]
2009-01-19 14:25 ` [PATCH 4/6] ide: fix comments in ide_config_drive_speed() Sergei Shtylyov
2009-01-19 13:03 ` [PATCH 5/6] ide: checkpatch.pl fixes for ide-iops.c Bartlomiej Zolnierkiewicz
2009-01-19 13:03 ` [PATCH 6/6] ide: move error handling code to ide-eh.c Bartlomiej Zolnierkiewicz
2009-01-19 14:19 ` [PATCH 0/6] ide: more core code housekeeping Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119130336.24745.7606.sendpatchset@localhost.localdomain \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).