Re: [RFC][PATCH] at91_ide driver

[Stanislaw Gruszka <stf_xl@wp.pl>]

Tuesday 20 January 2009 12:07:17 Sergei Shtylyov napisał(a):
> > do special things before access Task File and Data Register (functions 
> > set_8bit_mode() and set_16bit_mode()).
> 
>    That part really doesn't look well -- Atmel should have put more 
> though into it and make the register stride 2 bytes, so that 16-bit 
> access could alwys be used...
Actually it is possible (I realize when seeing pata_at32) when address
lines are connected in diffrent way, h/w trick is described in AVR32 ATA
application note. Only register addresses are multiplied by 2 then.
However Atmel reference documents for AT91 don't describe such
connection. I suppose AT91 evaluation boards are designed without the trick.
 
>   I then don't understand how are you submitting this as a part of 
> SAM9623EK board code...
I asked for comment not for submition (yet) :)

> > We did not tests on Atmel sam9263ek board, because we have no proper connector
> > for 1,8'' HDD.
> 
>    Not sure I've understood that. You have 1,8'' drive and the board has 
> stndard IDE connector?
Board has 44-pin male IDE connector (rather non standard one), we have no cable
or any device to connect. Kelvatek's board has Compact Flash connector, we use CF
card for testing. We currently ordered proper cable and IDE->CF adapter, so
I'll do tests on sam9263ek.

> > On PIO4 mode I achieve 4,5MB/s
> 
>    Seems a good result actually. How it was measured?
hdparm -t /dev/hda

I will comment other things soon.

Cheers
Stanislaw Gruszka