From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] icside: use struct ide_port_info also for PCB version 5 Date: Sat, 24 Jan 2009 16:44:16 +0100 Message-ID: <200901241644.16601.bzolnier@gmail.com> References: <200901241514.23036.bzolnier@gmail.com> <20090124145051.GA26833@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mu-out-0910.google.com ([209.85.134.187]:5703 "EHLO mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbZAXPoS (ORCPT ); Sat, 24 Jan 2009 10:44:18 -0500 In-Reply-To: <20090124145051.GA26833@flint.arm.linux.org.uk> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Russell King Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Saturday 24 January 2009, Russell King wrote: > On Sat, Jan 24, 2009 at 03:14:22PM +0100, Bartlomiej Zolnierkiewicz wrote: > > From: Bartlomiej Zolnierkiewicz > > Subject: [PATCH] icside: use struct ide_port_info also for PCB version 5 > > > > This fixes hwif->channel and drive->dn assignments. > > I really don't care about this driver anymore - people should > be using the PATA version instead. I really don't see major technical arguments for using libata version (especially after 2.6.29 IDE changes) but it's your call so if you want icside removed just send me a patch and I'll apply it (given that there are no complaints from users). [ No strong feelings here as it will allow me to better use my time and concentrate on working on code that people care about. ] > Nevertheless, this patch looks broken. > > > @@ -534,7 +538,7 @@ icside_register_v6(struct icside_state * > ^^^^^^^^^^^^^^^^^^ v6 function > > > d.dma_ops = NULL; > > } > > > > - ret = ide_host_register(host, NULL, hws); > > + ret = ide_host_register(host, &icside_v5_port_info, hws); > ^^^^^^^^^^^^^^^^^^^^^ v5 info Grrr.. and the other icside patch has v5->v6 mismatch. Thanks for noticing. I'll post corrected patches in few minutes.