linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Borislav Petkov <petkovbb@gmail.com>
Subject: Re: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense
Date: Tue, 27 Jan 2009 16:07:08 +0100	[thread overview]
Message-ID: <200901271607.10869.bzolnier@gmail.com> (raw)
In-Reply-To: <1233002440-4325-1-git-send-email-petkovbb@gmail.com>

On Monday 26 January 2009, Borislav Petkov wrote:
> There should be no functionality change resulting from this patch.
> 
> Suggested-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> ---
>  drivers/ide/ide-cd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index d3d5fb6..3907466 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -207,7 +207,7 @@ static void cdrom_queue_request_sense(ide_drive_t *drive, void *sense,
>  				      struct request *failed_command)
>  {
>  	struct cdrom_info *info		= drive->driver_data;
> -	struct request *rq		= &info->request_sense_request;
> +	struct request *rq		= &drive->request_sense_rq;

Don't we want to also remove now unused ->request_sense_request?

  parent reply	other threads:[~2009-01-27 15:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 20:40 [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense Borislav Petkov
2009-01-26 20:40 ` [PATCH 2/3] ide: improve debugging scheme Borislav Petkov
2009-01-27  6:19   ` Borislav Petkov
2009-01-27 15:22     ` Bartlomiej Zolnierkiewicz
2009-01-26 20:40 ` [PATCH 3/3] ide-cd: fix DMA for non bio-backed requests Borislav Petkov
2009-01-27 15:06   ` Bartlomiej Zolnierkiewicz
2009-01-27 15:07 ` Bartlomiej Zolnierkiewicz [this message]
2009-01-27 16:47   ` [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense Borislav Petkov
2009-02-01 16:04     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901271607.10869.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).