linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: linux-ide@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
	Tejun Heo <tj@kernel.org>,
	gpanco@tiscali.it, Andrew Morton <akpm@linux-foundation.org>,
	stable@kernel.org
Subject: Re: [stable] [Bugme-new] [Bug 12351] New: sata_nv hotplug not work in 2.6.27.10
Date: Tue, 3 Feb 2009 14:21:35 -0800	[thread overview]
Message-ID: <20090203222135.GA13073@kroah.com> (raw)
In-Reply-To: <4987A63A.1020801@gmail.com>

On Mon, Feb 02, 2009 at 08:04:42PM -0600, Robert Hancock wrote:
> Greg KH wrote:
>> On Fri, Jan 16, 2009 at 08:38:18PM -0600, Robert Hancock wrote:
>>> Greg KH wrote:
>>>> On Tue, Jan 06, 2009 at 06:19:44PM -0600, Robert Hancock wrote:
>>>>> Giovanni Pancotti wrote:
>>>>>> On Monday 05 January 2009, alle 18:57, Robert Hancock wrote:
>>>>>>
>>>>>>>>> Hardware Environment:x86 ASUS M2N-E
>>>>>>> OK, this is an MCP61 board. We're now using softreset instead of 
>>>>>>> hardreset on hotplug and apparently that doesn't work. Thing is that:
>>>>>> no, it is not MCP61, but MCP55:
>>>>> Ahh, ok, that is less contradictory then :-) Presumably we should still 
>>>>> be using hardreset on that chipset.
>>>> So, do we know how to solve this in the 2.6.27.y tree?
>>> Can you try reverting this patch?
>>>
>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=3c324283e6cdb79210cf7975c3e40d3ba3e672b2
>>>
>>> This likely isn't a proper fix as it will probably re-break some other 
>>> chipsets but it will confirm what the problem is in this case. It looks 
>>> like this patch changed MCP55 to inherit from generic_ops instead of 
>>> common_ops which caused it to use soft reset instead of hard reset. Not 
>>> sure if that was intentional or not.. Tejun?
>> I don't want to revert that, as I don't want to break anything else :)
>
> That was directed at the reporter :-) However, hopefully this patch in 
> current git will resolve the problem:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2d775708bc6613f1be47f1e720781343341ecc94

Ah nice, I'll queue that one up as well :)

thanks,

greg k-h

      reply	other threads:[~2009-02-03 22:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-12351-10286@http.bugzilla.kernel.org/>
2009-01-05 23:36 ` [Bugme-new] [Bug 12351] New: sata_nv hotplug not work in 2.6.27.10 Andrew Morton
2009-01-06  0:57   ` Robert Hancock
2009-01-06 10:27     ` Giovanni Pancotti
2009-01-07  0:19       ` Robert Hancock
2009-01-15 18:45         ` [stable] " Greg KH
2009-01-17  2:38           ` Robert Hancock
2009-02-02 22:55             ` Greg KH
2009-02-03  2:04               ` Robert Hancock
2009-02-03 22:21                 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090203222135.GA13073@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=gpanco@tiscali.it \
    --cc=hancockrwd@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).