From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [stable] [Bugme-new] [Bug 12351] New: sata_nv hotplug not work in 2.6.27.10 Date: Tue, 3 Feb 2009 14:21:35 -0800 Message-ID: <20090203222135.GA13073@kroah.com> References: <20090105153644.8a0eea74.akpm@linux-foundation.org> <4962AC5C.1000605@shaw.ca> <20090106102758.GA7309@libero.it> <4963F520.4060500@shaw.ca> <20090115184502.GC10674@kroah.com> <4971449A.9010601@shaw.ca> <20090202225500.GB32075@kroah.com> <4987A63A.1020801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kroah.org ([198.145.64.141]:36689 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752099AbZBCWmN (ORCPT ); Tue, 3 Feb 2009 17:42:13 -0500 Content-Disposition: inline In-Reply-To: <4987A63A.1020801@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Robert Hancock Cc: linux-ide@vger.kernel.org, bugme-daemon@bugzilla.kernel.org, Tejun Heo , gpanco@tiscali.it, Andrew Morton , stable@kernel.org On Mon, Feb 02, 2009 at 08:04:42PM -0600, Robert Hancock wrote: > Greg KH wrote: >> On Fri, Jan 16, 2009 at 08:38:18PM -0600, Robert Hancock wrote: >>> Greg KH wrote: >>>> On Tue, Jan 06, 2009 at 06:19:44PM -0600, Robert Hancock wrote: >>>>> Giovanni Pancotti wrote: >>>>>> On Monday 05 January 2009, alle 18:57, Robert Hancock wrote: >>>>>> >>>>>>>>> Hardware Environment:x86 ASUS M2N-E >>>>>>> OK, this is an MCP61 board. We're now using softreset instead of >>>>>>> hardreset on hotplug and apparently that doesn't work. Thing is that: >>>>>> no, it is not MCP61, but MCP55: >>>>> Ahh, ok, that is less contradictory then :-) Presumably we should still >>>>> be using hardreset on that chipset. >>>> So, do we know how to solve this in the 2.6.27.y tree? >>> Can you try reverting this patch? >>> >>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=3c324283e6cdb79210cf7975c3e40d3ba3e672b2 >>> >>> This likely isn't a proper fix as it will probably re-break some other >>> chipsets but it will confirm what the problem is in this case. It looks >>> like this patch changed MCP55 to inherit from generic_ops instead of >>> common_ops which caused it to use soft reset instead of hard reset. Not >>> sure if that was intentional or not.. Tejun? >> I don't want to revert that, as I don't want to break anything else :) > > That was directed at the reporter :-) However, hopefully this patch in > current git will resolve the problem: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2d775708bc6613f1be47f1e720781343341ecc94 Ah nice, I'll queue that one up as well :) thanks, greg k-h