From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, Andrew Victor <avictor.za@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 3/3 v2] AT91: initialize Compact Flash on AT91SAM9263 cpu
Date: Fri, 6 Feb 2009 14:33:19 +0100 [thread overview]
Message-ID: <200902061433.19490.stf_xl@wp.pl> (raw)
In-Reply-To: <498C2A57.6010908@ru.mvista.com>
Friday 06 February 2009 13:17:27 Sergei Shtylyov napisał(a):
> > +void __init at91_add_device_cf(struct at91_cf_data *data)
> > +{
> >
> [...]
> > + /* enable EBI controlled pins */
> > + at91_set_A_periph(AT91_PIN_PD5, 1); /* NWAIT */
> > + at91_set_A_periph(AT91_PIN_PD8, 0); /* CFCE1 */
> > + at91_set_A_periph(AT91_PIN_PD9, 0); /* CFCE2 */
> > + at91_set_A_periph(AT91_PIN_PD14, 0); /* CFNRW */
> > +
> > + if (data->flags & AT91_CF_TRUE_IDE)
> >
>
> Again, I've probably missed something but this structre doesn't have
> the 'flags' field. How is this suppoed to compile?
Patch 2/3 add flags to the at91_cf_data structure.
Stanislaw Gruszka
next prev parent reply other threads:[~2009-02-06 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 11:14 [PATCH 3/3 v2] AT91: initialize Compact Flash on AT91SAM9263 cpu Stanislaw Gruszka
2009-02-06 12:03 ` Sergei Shtylyov
2009-02-06 13:32 ` Stanislaw Gruszka
2009-02-15 16:00 ` Sergei Shtylyov
2009-02-15 16:07 ` Sergei Shtylyov
2009-02-06 12:17 ` Sergei Shtylyov
2009-02-06 13:33 ` Stanislaw Gruszka [this message]
2009-02-06 17:23 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902061433.19490.stf_xl@wp.pl \
--to=stf_xl@wp.pl \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).