From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 0/6] ide: more unifications of ATA and ATAPI support Date: Wed, 11 Feb 2009 08:16:40 +0100 Message-ID: <20090211071640.GD937@gollum.tnic> References: <20090209231945.32406.14874.sendpatchset@localhost.localdomain> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from fk-out-0910.google.com ([209.85.128.191]:50370 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbZBKHQn (ORCPT ); Wed, 11 Feb 2009 02:16:43 -0500 Content-Disposition: inline In-Reply-To: <20090209231945.32406.14874.sendpatchset@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Feb 10, 2009 at 12:19:45AM +0100, Bartlomiej Zolnierkiewicz wrote: > > After this patchset we have a valid struct ide_cmd available also for > ATA_CMD_PACKET commands and comparing struct ide_atapi_pc with ide_cmd it > seems that there are many similarities between them and that we may just > merge both structs (this should also allow us to unify ide-cd code with > non-ide-cd one in ide-atapi.c later). From the quick look the only gotcha > is REQUEST SENSE handling, ->request_sense_pc needs to be converted to > ->request_sense_cmd and we have to be careful with choosing right 'cmd' > in *_issue_pc()... > > Borislav, please take a look and tell me what do you think about it > (also feel free to go ahead with patches :-)... Yep, like it, especially the idea of a unified ide_cmd thingy and removing the atapi_pc :). ACK. -- Regards/Gruss, Boris.