Re: [PATCH 3/3 v3] AT91: initialize Compact Flash on AT91SAM9263 cpu

[Stanislaw Gruszka <stf_xl@wp.pl>]

Hi

Wednesday 11 February 2009 21:03:29 Andrew Victor napisał(a):
> > +       if (data->flags & AT91_CF_TRUE_IDE) {
> > +               /* check if device is present */
> > +               if (data->det_pin && at91_get_gpio_value(data->det_pin) != 0) {
> > +                       printk(KERN_ERR "AT91 CF True IDE: no device detected\n");
> > +                       return;
> > +               }
> > +               if (data->rst_pin) {
> > +                       /* reset the card */
> > +                       at91_set_gpio_output(data->rst_pin, 0);
> > +                       /* wait as defined in ATA7 vol2 (rev 4a) figure 36 */
> > +                       udelay(25);
> > +                       at91_set_gpio_output(data->rst_pin, 1);
> > +               }
> 
> Shouldn't this rather be done in the at91_ide driver?
> I don't want to duplicate it in all the different at91sam9XX_devices.c files.

Ok, I'll move detection stuff to the driver. Not sure about reset, see my 
previous mail on this issue. Could we move the reset into driver and
risk system boot with device which possibly generate interrupts?
Or perhaps we can remove reset as whole?

> You could also define two separate "CF type" devices - one for CS4,
> another for CS5.
> That would allow for two independent "CF type" interfaces to be used
> at the same time (see at91sam9260_devices.c in maxim.org.za patches).

I saw sam9260 code before and I refused idea of doing two CF devices 
interfaces. AFAIK there are no boards we two CF slots (or separate one
IDE and one CF slot), are they? I don't think someone really need such 
board (I could be wrong). If there become a board with two interfaces, 
then new patch can be done which extend the code.
 
Cheers
Stanislaw Gruszka