Re: [PATCH 3/3 v3] AT91: initialize Compact Flash on AT91SAM9263 cpu

[Stanislaw Gruszka <stf_xl@wp.pl>]

Thursday 12 February 2009 10:33:56 Stanislaw Gruszka napisał(a):
> > Shouldn't this rather be done in the at91_ide driver?
> > I don't want to duplicate it in all the different at91sam9XX_devices.c files.
> 
> Ok, I'll move detection stuff to the driver. Not sure about reset, see my 
> previous mail on this issue. Could we move the reset into driver and
> risk system boot with device which possibly generate interrupts?
> Or perhaps we can remove reset as whole?

I'll finally move resetting stuff into board specific file and detect code
into driver.

> > You could also define two separate "CF type" devices - one for CS4,
> > another for CS5.
> > That would allow for two independent "CF type" interfaces to be used
> > at the same time (see at91sam9260_devices.c in maxim.org.za patches).
> 
> I saw sam9260 code before and I refused idea of doing two CF devices 
> interfaces. AFAIK there are no boards we two CF slots (or separate one
> IDE and one CF slot), are they? I don't think someone really need such 
> board (I could be wrong). If there become a board with two interfaces, 
> then new patch can be done which extend the code.

I see no discussion here is possible :) , ok I'll revrite the code in form like 
at91sam9260_devices.c has.

Cheers
Stanislaw Gruszka