From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <petkovbb@gmail.com>
Subject: Re: [PATCH 0/10] ide: flags query macros
Date: Tue, 17 Feb 2009 15:33:28 +0100 [thread overview]
Message-ID: <200902171533.29135.bzolnier@gmail.com> (raw)
In-Reply-To: <1234699692-9452-1-git-send-email-petkovbb@gmail.com>
On Sunday 15 February 2009, Borislav Petkov wrote:
> Hi,
>
> this series adds the drive->atapi_flags and drive->dev_flags macro wrappers
> we discussed. The idea was to make the code more readable and this has
> been my main concern when coming up with the macro naming, therefore
> some macro names appear a tad more descriptive than the flag itself.
>
> drivers/ide/cmd640.c | 2 +-
> drivers/ide/ht6560b.c | 3 +-
> drivers/ide/ide-atapi.c | 15 ++++++-------
> drivers/ide/ide-cd.c | 44 ++++++++++++++++++++-------------------
> drivers/ide/ide-cd_ioctl.c | 18 +++++++---------
> drivers/ide/ide-devsets.c | 8 ++----
> drivers/ide/ide-disk.c | 32 ++++++++++++++--------------
> drivers/ide/ide-disk_proc.c | 2 +-
> drivers/ide/ide-dma.c | 3 +-
> drivers/ide/ide-eh.c | 17 +++++++--------
> drivers/ide/ide-floppy.c | 6 ++--
> drivers/ide/ide-floppy_ioctl.c | 2 +-
> drivers/ide/ide-gd.c | 14 ++++++------
> drivers/ide/ide-io.c | 9 +++----
> drivers/ide/ide-ioctls.c | 6 ++--
> drivers/ide/ide-iops.c | 6 ++--
> drivers/ide/ide-lib.c | 2 +-
> drivers/ide/ide-park.c | 11 ++++-----
> drivers/ide/ide-pm.c | 2 +-
> drivers/ide/ide-probe.c | 36 +++++++++++++++++---------------
> drivers/ide/ide-proc.c | 2 +-
> drivers/ide/ide-tape.c | 12 +++++-----
> drivers/ide/ide-taskfile.c | 16 +++++---------
> drivers/ide/ns87415.c | 5 +--
> drivers/ide/pdc202xx_old.c | 4 +-
> drivers/ide/sc1200.c | 2 +-
> drivers/ide/trm290.c | 4 +-
> 27 files changed, 136 insertions(+), 147 deletions(-)
One more thing I forgot yesterday:
Since it is not a lot of modified lines and the change is rather
straightforward it could as well be done in a single patch...
Thanks,
Bart
next prev parent reply other threads:[~2009-02-17 15:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 12:08 [PATCH 0/10] ide: flags query macros Borislav Petkov
2009-02-15 12:08 ` [PATCH 01/10] ide: add " Borislav Petkov
2009-02-15 13:35 ` Sam Ravnborg
2009-02-15 18:01 ` Borislav Petkov
2009-02-15 20:51 ` Sam Ravnborg
2009-02-16 21:07 ` Bartlomiej Zolnierkiewicz
2009-02-15 12:08 ` [PATCH 02/10] ide-cd: use " Borislav Petkov
2009-02-15 12:08 ` [PATCH 03/10] ide-floppy: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 04/10] ide-tape: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 05/10] ide-atapi: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 06/10] ide-disk: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 07/10] ide-devsets: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 08/10] ide-eh: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 09/10] ide-probe: " Borislav Petkov
2009-02-15 12:08 ` [PATCH 10/10] ide: use flags query macros in the remaining ide code Borislav Petkov
2009-02-16 22:17 ` [PATCH 0/10] ide: flags query macros Bartlomiej Zolnierkiewicz
2009-02-17 14:33 ` Bartlomiej Zolnierkiewicz [this message]
2009-02-23 7:04 ` Borislav Petkov
2009-02-23 7:34 ` Sam Ravnborg
2009-02-23 8:25 ` Borislav Petkov
2009-02-26 21:35 ` Bartlomiej Zolnierkiewicz
2009-02-27 6:38 ` Borislav Petkov
2009-02-27 8:21 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902171533.29135.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=petkovbb@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).