From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-ide@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: ide_timer_expiry() - shouldn't 'wait' be int?
Date: Mon, 2 Mar 2009 15:50:45 +0100 [thread overview]
Message-ID: <200903021550.45608.bzolnier@gmail.com> (raw)
In-Reply-To: <49ABEAC0.40407@gmail.com>
On Monday 02 March 2009, Roel Kluin wrote:
> vi drivers/ide/ide-io.c +906 and note:
>
> void ide_timer_expiry (unsigned long data)
> {
> ide_expiry_t *expiry = hwif->expiry;
> ...
> unsigned long wait = -1;
> ...
> if (expiry) {
> ...
> wait = expiry(drive);
> if (wait > 0) { /* continue */
>
> also note that in include/linux/ide.h:883:
>
> typedef int (ide_expiry_t)(ide_drive_t *);
>
> doesn't this mean that expiry returns int, and wait therefore should
> be int as well?
It does... and it seems like it could cause insanely long timeouts for:
* ATA_DMA_ERR error in dma_timer_expiry()
* commands without ->expiry in tc86c001_timer_expiry()
(TC86C001 IDE controller only)
This is 2.6.29 material, care to make a patch?
Thanks,
Bart
next prev parent reply other threads:[~2009-03-02 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 14:18 ide_timer_expiry() - shouldn't 'wait' be int? Roel Kluin
2009-03-02 14:38 ` Sergei Shtylyov
2009-03-02 14:58 ` Bartlomiej Zolnierkiewicz
2009-03-02 15:17 ` Roel Kluin
2009-03-02 15:29 ` Bartlomiej Zolnierkiewicz
2009-03-02 15:53 ` Sergei Shtylyov
2009-03-05 12:59 ` Bartlomiej Zolnierkiewicz
2009-03-02 15:39 ` Sergei Shtylyov
2009-03-02 15:45 ` Bartlomiej Zolnierkiewicz
2009-03-02 15:45 ` Sergei Shtylyov
2009-03-02 15:51 ` Bartlomiej Zolnierkiewicz
2009-03-02 16:15 ` Bartlomiej Zolnierkiewicz
2009-03-02 14:50 ` Bartlomiej Zolnierkiewicz [this message]
2009-03-02 15:43 ` Sergei Shtylyov
2009-03-02 15:51 ` Bartlomiej Zolnierkiewicz
2009-03-02 15:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903021550.45608.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).