* [PATCH] ide-iops: fix odd-length ATAPI PIO transfers
@ 2009-03-05 14:36 Sergei Shtylyov
2009-03-05 15:03 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2009-03-05 14:36 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide, stable
Commit 9567b349f7e7dd7e2483db99ee8e4a6fe0caca38 (ide: merge ->atapi_*put_bytes
and ->ata_*put_data methods) introduced a regression WRT the odd-length ATAPI
PIO transfers -- the final word didn't get written (causing command timeouts).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
This patch is against the recent Linus' tree...
drivers/ide/ide-iops.c | 2 ++
1 files changed, 2 insertions(+)
Index: linux-2.6/drivers/ide/ide-iops.c
===================================================================
--- linux-2.6.orig/drivers/ide/ide-iops.c
+++ linux-2.6/drivers/ide/ide-iops.c
@@ -315,6 +315,8 @@ void ide_output_data(ide_drive_t *drive,
u8 io_32bit = drive->io_32bit;
u8 mmio = (hwif->host_flags & IDE_HFLAG_MMIO) ? 1 : 0;
+ len++;
+
if (io_32bit) {
unsigned long uninitialized_var(flags);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ide-iops: fix odd-length ATAPI PIO transfers
2009-03-05 14:36 [PATCH] ide-iops: fix odd-length ATAPI PIO transfers Sergei Shtylyov
@ 2009-03-05 15:03 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-03-05 15:03 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, stable
On Thursday 05 March 2009, Sergei Shtylyov wrote:
> Commit 9567b349f7e7dd7e2483db99ee8e4a6fe0caca38 (ide: merge ->atapi_*put_bytes
> and ->ata_*put_data methods) introduced a regression WRT the odd-length ATAPI
> PIO transfers -- the final word didn't get written (causing command timeouts).
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-05 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-05 14:36 [PATCH] ide-iops: fix odd-length ATAPI PIO transfers Sergei Shtylyov
2009-03-05 15:03 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).