linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	sshtylyov@ru.mvista.com, linux-ide@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata: add CFA specific identify data words
Date: Thu, 5 Mar 2009 17:20:23 +0100	[thread overview]
Message-ID: <200903051720.24108.bzolnier@gmail.com> (raw)
In-Reply-To: <20090305154040.GA23182@havoc.gtf.org>

On Thursday 05 March 2009, Jeff Garzik wrote:
> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> Declare and use constants for CFA specific identify data words 162 and 163.
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> 
> ---
> Sergei said:
> This patch is against the current pata-2.6 series. I'd prefer that Bart merged
> it thru his tree as my next patch adding CF mode support to IDE depends on it.
> 
> jgarzik adds:
> I didn't see this in your latest submission, Bart.  It is simple and

Simply because I haven't yet got to those patches + Sergei mentioned
that they need to be tested yet.

> harmless and might as well go ahead upstream, to eliminate the
> cross-tree dependency that Sergei speaks of (his patch also touched
> drivers/ata/libata-core.c, but I excluded that from below).

Fine with me if this makes things easier for everyone.

I updated git pull request with this patch fixing patch summary
(this is not libata specific change) and patch description (constants
are not currently unused) while at it.

From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: [PATCH] ata: add CFA specific identify data words

Declare CFA specific identify data words 162 and 163 for future use.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
[bart: update patch summary/description]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 include/linux/ata.h       |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Index: linux-2.6/include/linux/ata.h
===================================================================
--- linux-2.6.orig/include/linux/ata.h
+++ linux-2.6/include/linux/ata.h
@@ -89,6 +89,8 @@ enum {
 	ATA_ID_DLF		= 128,
 	ATA_ID_CSFO		= 129,
 	ATA_ID_CFA_POWER	= 160,
+	ATA_ID_CFA_KEY_MGMT	= 162,
+	ATA_ID_CFA_MODES	= 163,
 	ATA_ID_ROT_SPEED	= 217,
 	ATA_ID_PIO4		= (1 << 1),

      reply	other threads:[~2009-03-05 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05 15:40 [PATCH] libata: add CFA specific identify data words Jeff Garzik
2009-03-05 16:20 ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903051720.24108.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sshtylyov@ru.mvista.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).