Re: [PATCH 08/10] ide: move ide_map_sg() call out from ->dma_setup method

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Wednesday 11 March 2009, Sergei Shtylyov wrote:
> Hello.
> 
> Bartlomiej Zolnierkiewicz wrote:
> 
> >>>Move ide_map_sg() call from ->dma_setup implementations
> >>>and ide_destroy_dmatable() one from *_build_dmatable() to
> >>>ide_dma_prepare().
> 
> >>>There should be no functional changes caused by this patch.
> 
> >>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> 
> >>[...]
> >>
> >>>Index: b/drivers/ide/au1xxx-ide.c
> >>>===================================================================
> >>>--- a/drivers/ide/au1xxx-ide.c
> >>>+++ b/drivers/ide/au1xxx-ide.c
> >>>@@ -272,9 +272,7 @@ static int auide_build_dmatable(ide_driv
> >>> 	if (count)
> >>> 		return 1;
> >>> 
> >>>- use_pio_instead:
> >>>-	ide_destroy_dmatable(drive);
> >>>-
> >>>+use_pio_instead:
> 
> >>   Could you please get rid of goto and label too, while at it?
> 
> > Sorry but since this patch has been already merged
> 
>     Merged where?!

To pata tree, two weeks ago.

I try to limit touching merged stuff as much as possible so people working
with pata tree don't get surprised too much (sometimes it is impossible but
this doesn't discourage me from trying).  

[ Some people may argue that existing stuff shouldn't change at all but
  IMO it is all case specific and this trade-off is acceptable for fixing
  regressions / preserving bisectability... ]

> > it would be too much work/noise for too little gain IMO.
> 
>     Will you take a reworked patch from me?

Well, OK this time if it won't cause rejects in later patches... though stuff
like that is really much more efficient done in incremental patches.

Thanks,
Bart