Re: [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe

[Frans Pop <elendil@planet.nl>]

On Friday 13 March 2009, Mark Lord wrote:
> --- old/drivers/ata/sata_mv.c	2009-03-12 10:23:41.000000000 -0400
> +++ new/drivers/ata/sata_mv.c	2009-03-13 09:03:47.000000000 -0400
> @@ -1455,9 +1455,8 @@
>  		struct ata_port *this_ap = host->ports[port];
>  		struct mv_port_priv *pp = this_ap->private_data;
>
> -		if (pp->pp_flags & MV_PP_FLAG_EDMA_EN)
> -			if (pp->pp_flags & MV_PP_FLAG_NCQ_EN)
> -				return;
> +		if (pp->pp_flags & MV_PP_FLAG_NCQ_EN)
> +			return;

I expect that if NCQ is disabled using the method I've used so far, the 
led behavior would still be correct, but...

The reason I included the test for both in my patches is that if DMA gets 
disabled (which IIUC also disables NCQ) only the MV_PP_FLAG_EDMA_EN flag 
gets unset in mv_stop_edma, and not the NCQ flag (AFAICT). So that would 
result in blink mode remaining enabled while it shouldn't be.

I have so far not tested the led bahavior when DMA is disabled (not even 
sure if that's possible for a running system).

Note that e.g. the last if statement in mv_qc_defer also tests both.

Cheers,
FJP