* [PATCH 1/2] ide-disk: use ATA_ERR
@ 2009-03-16 15:33 Sergei Shtylyov
2009-03-16 17:59 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2009-03-16 15:33 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide
Make use of ATA_ERR instead of hard-coded value in idedisk_set_max_address()
and idedisk_read_native_max_address().
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
This patch is atop of the latest pata-2.6 series...
drivers/ide/ide-disk.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/ide/ide-disk.c
===================================================================
--- linux-2.6.orig/drivers/ide/ide-disk.c
+++ linux-2.6/drivers/ide/ide-disk.c
@@ -227,7 +227,7 @@ static u64 idedisk_read_native_max_addre
ide_no_data_taskfile(drive, &cmd);
/* if OK, compute maximum address value */
- if ((tf->status & 0x01) == 0)
+ if (!(tf->status & ATA_ERR))
addr = ide_get_lba_addr(tf, lba48) + 1;
return addr;
@@ -267,7 +267,7 @@ static u64 idedisk_set_max_address(ide_d
ide_no_data_taskfile(drive, &cmd);
/* if OK, compute maximum address value */
- if ((tf->status & 0x01) == 0)
+ if (!(tf->status & ATA_ERR))
addr_set = ide_get_lba_addr(tf, lba48) + 1;
return addr_set;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] ide-disk: use ATA_ERR
2009-03-16 15:33 [PATCH 1/2] ide-disk: use ATA_ERR Sergei Shtylyov
@ 2009-03-16 17:59 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-03-16 17:59 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide
On Monday 16 March 2009, Sergei Shtylyov wrote:
> Make use of ATA_ERR instead of hard-coded value in idedisk_set_max_address()
> and idedisk_read_native_max_address().
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-16 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-16 15:33 [PATCH 1/2] ide-disk: use ATA_ERR Sergei Shtylyov
2009-03-16 17:59 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).