From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH 1/2] ide: turn selectproc() method into dev_select() method
Date: Fri, 20 Mar 2009 20:02:53 +0100 [thread overview]
Message-ID: <200903202002.55510.bzolnier@gmail.com> (raw)
In-Reply-To: <49C2688A.3070808@ru.mvista.com>
On Thursday 19 March 2009, Sergei Shtylyov wrote:
> Hello, I wrote:
>
> > Turn selectproc() method into dev_select() method by teaching it to write to the
> > device register and moving it from 'struct ide_port_ops' to 'struct ide_tp_ops'.
>
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> [...]
>
> > Index: linux-2.6/drivers/ide/trm290.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/ide/trm290.c
> > +++ linux-2.6/drivers/ide/trm290.c
> > @@ -171,10 +171,11 @@ static void trm290_prepare_drive (ide_dr
> > local_irq_restore(flags);
> > }
> >
> > -static void trm290_selectproc (ide_drive_t *drive)
> > +static void trm290_dev_select(ide_drive_t *drive)
> > {
> > trm290_prepare_drive(drive, !!(drive->dev_flags & IDE_DFLAG_USING_DMA));
> > -}
> > +
> > + outb(drive->select | ATA_DEVICE_OBS, drive->hwif->io_ports.device_addr);}
>
> Oops, I keep forgetting about running checkpatch.pl first. :-<
> Bart, do I need to repost, or you can fix it while applying?
fixed while applying
ditto for:
drivers/ide/ns87415.c:314: error: ‘ns87415_tp_ops’ undeclared here (not in a function)
make[1]: *** [drivers/ide/ns87415.o] Error 1
make: *** [drivers/ide/ns87415.o] Error 2
next prev parent reply other threads:[~2009-03-20 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 15:31 [PATCH 1/2] ide: turn selectproc() method into dev_select() method Sergei Shtylyov
2009-03-19 15:45 ` Sergei Shtylyov
2009-03-20 19:02 ` Bartlomiej Zolnierkiewicz [this message]
2009-03-23 10:47 ` Sergei Shtylyov
2009-03-19 21:57 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903202002.55510.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).