Re: bug in use-ide_pio_bytes patch?

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

Hi,

On Monday 23 March 2009, Tejun Heo wrote:
> Hello, Bartlomiej.
> 
> I've been looking at the pata-2.6 patches and use-ide_pio_bytes patch
> contains the following snippet.
> 
>   void ide_init_pc(struct ide_atapi_pc *pc)
>   {
> 	 memset(pc, 0, sizeof(*pc));
>  @@ -351,6 +308,9 @@ static ide_startstop_t ide_pc_intr(ide_d
> 			 pc->xferred = pc->req_xfer;
> 			 if (drive->pc_update_buffers)
> 				 drive->pc_update_buffers(drive, pc);
>  +
>  +			if (drive->media == ide_floppy)
>  +				ide_complete_rq(drive, 0, blk_rq_bytes(rq));
> 		 }
> 		 debug_log("%s: DMA finished\n", drive->name);
> 	 }
> 
> It completes ide_floppy requests in the DMA handling block; however,
> those requests are gonna be completed again later in the regular
> completion path again.  I think the above part can be simply dropped?

I'm not sure I get it -- could you point me to the other completion path?

Thanks,
Bart