Re: [PATCH] IDE cable detection on Apple PowerBook

[TOMARI Hisanobu <posco.grubb@gmail.com>]

On Mon, 23 Mar 2009 21:09:24 +0100
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> On Monday 23 March 2009, TOMARI Hisanobu wrote:
> > On Mon, 23 Mar 2009 13:57:03 +0300
> > Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> > 
> > >     Unacceptable style, brace should be on the same line with *if*; run your 
> > > patch thru scripts/checkpatch.pl please...
> > Thank you for telling me the error. Now, this one should be all right.
> > 
> > ---
> > 
> > Signed-off-by: TOMARI Hisanobu <posco.grubb@gmail.com>
> > This patch against 2.6.28.8 modifies the behavior of 80c cable detection 
> > of drivers/ide/pmac.c.
> > As IDE cable used on Apple PowerBook/iBook laptops are always of "Short 40" 
> > type when the firmware says it's 80 conductor one, the cable detection should 
> > return ATA_CBL_PATA40_SHORT on those machines.
> > This enables to automatically use UDMA5 even with drives that doesn't correctly 
> > detect those cables on Apple laptops.
> 
> applied
> 
> PS please keep the following ordering in future:
> 
> - patch description
> - S-o-B line
> - "---" line
> 
> to allow easier/automatic merging of patches
Roger that. Thanks!

-- 
TOMARI, Hisanobu