From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 13/14] ide-atapi: use bio for request sense Date: Sat, 28 Mar 2009 09:43:24 +0100 Message-ID: <20090328084324.GA1742@liondog.tnic> References: <1237910776-10983-1-git-send-email-tj@kernel.org> <1237910776-10983-14-git-send-email-tj@kernel.org> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-bw0-f169.google.com ([209.85.218.169]:59834 "EHLO mail-bw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbZC1Inc (ORCPT ); Sat, 28 Mar 2009 04:43:32 -0400 Content-Disposition: inline In-Reply-To: <1237910776-10983-14-git-send-email-tj@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: bzolnier@gmail.com, linux-kernel@vger.kernel.org, axboe@kernel.dk, linux-ide@vger.kernel.org On Wed, Mar 25, 2009 at 01:06:15AM +0900, Tejun Heo wrote: > Impact: unify request data buffer handling > > rq->data is used mostly to pass kernel buffer through request queue > without using bio. There are only a couple of places which still do > this in kernel and converting to bio isn't difficult. > > This patch converts ide-atapi to use bio instead of rq->data. For > ide_queue_pc_tail() which can block, blk_rq_map_kern() is used. For > ide_queue_pc_head() which is used for request sense and called from > atomic context, drive->request_sense_bio and ->request_sense_bvec[2] > are added and used via bio_map_kern_prealloc(). > > ide-tape is updated to map sg for special requests. > > This change makes all ide-atapi commands except for tape bh ones use > bio. Drop tp_ops->output/input_data path from ide_pc_intr(). > > Signed-off-by: Tejun Heo > Cc: Jens Axboe Acked-by: Borislav Petkov -- Regards/Gruss, Boris.