From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-ide@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Subject: Re: [PATCH] de: drivers/ide/ide-atapi.c needs <linux/scatterlist.h>
Date: Mon, 30 Mar 2009 22:29:31 +0200 [thread overview]
Message-ID: <200903302229.31846.bzolnier@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903292229400.23398@anakin>
On Sunday 29 March 2009, Geert Uytterhoeven wrote:
> On m68k:
> | drivers/ide/ide-atapi.c: In function 'ide_io_buffers':
> | drivers/ide/ide-atapi.c:87: error: implicit declaration of function 'sg_page'
> | drivers/ide/ide-atapi.c:87: warning: passing argument 1 of 'PageHighMem' makes pointer from integer without a cast
> | drivers/ide/ide-atapi.c:91: warning: passing argument 1 of 'kmap_atomic' makes pointer from integer without a cast
> | drivers/ide/ide-atapi.c:96: error: implicit declaration of function 'sg_virt'
> | drivers/ide/ide-atapi.c:96: warning: assignment makes pointer from integer without a cast
> | drivers/ide/ide-atapi.c:107: error: implicit declaration of function 'sg_next'
> | drivers/ide/ide-atapi.c:107: warning: assignment makes pointer from integer without a cast
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
thanks, applied
[ Dmitri, sorry but m68k was faster than MIPS this time ;) ]
> ---
> No idea where it got introduced. 2.6.29 was fine.
Hmm... the issue went unnoticed because it was mitigated in linux-next
by ide_pio_bytes() conversion (resulting in ide_io_buffers() removal)...
> drivers/ide/ide-atapi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c
> index 6adc5b4..445d157 100644
> --- a/drivers/ide/ide-atapi.c
> +++ b/drivers/ide/ide-atapi.c
> @@ -6,6 +6,8 @@
> #include <linux/cdrom.h>
> #include <linux/delay.h>
> #include <linux/ide.h>
> +#include <linux/scatterlist.h>
> +
> #include <scsi/scsi.h>
>
> #ifdef DEBUG
next prev parent reply other threads:[~2009-03-30 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 20:33 [PATCH] de: drivers/ide/ide-atapi.c needs <linux/scatterlist.h> Geert Uytterhoeven
2009-03-30 20:29 ` Bartlomiej Zolnierkiewicz [this message]
2009-03-31 7:05 ` Geert Uytterhoeven
2009-04-02 10:56 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903302229.31846.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=dmitri.vorobiev@movial.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).