From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-ide@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] ide: falconide/q40ide - Use __ide_mm_{in,out}sw() for data transfer
Date: Thu, 2 Apr 2009 20:50:51 +0200 [thread overview]
Message-ID: <200904022050.52002.bzolnier@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0904012243060.29342@anakin>
On Wednesday 01 April 2009, Geert Uytterhoeven wrote:
> Both of commits f94116aeec7a299640dd692128e1d22178affa8d ("ide: cleanup
> <asm-m68k/ide.h>") and 15a453a955f89f6545118770c669b52e925368bd ("ide: include
> <asm/ide.h> only when needed") break falconide:
>
> | Uniform Multi-Platform E-IDE driver
> | ide: Falcon IDE controller
> | Probing IDE interface ide0...
> | hda: Sarge m68k, ATA DISK drive
> | ide0 at 0xfff00000 on irq 15 (serialized)
> | ide-gd driver 1.18
> | hda: max request size: 128KiB
> | hda: 2118816 sectors (1084 MB) w/256KiB Cache, CHS=2102/16/63
> | hda:<4>hda: lost interrupt
>
> This happens because falconide relies on {in,out}sw() being redefined in
> <asm/ide.h>, as included by <linux/ide.h>, which is no longer the case.
> Use __ide_mm_{in,out}sw() from <asm/ide.h> instead, just like
> ide_{in,out}put_data() do.
>
> The same problem seems to exist in q40ide.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
applied
Many thanks for fixing this issue and the IRQF_SHARED one!
prev parent reply other threads:[~2009-04-02 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 20:43 [PATCH] ide: falconide/q40ide - Use __ide_mm_{in,out}sw() for data transfer Geert Uytterhoeven
2009-04-02 18:50 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904022050.52002.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).